ruby parametric: drop linux/amd64 platform pin#6987
Draft
bm1549 wants to merge 1 commit into
Draft
Conversation
The Ruby parametric Dockerfile was the only one in `utils/build/docker/` with a `--platform=linux/amd64` pin on its FROM line. The other eight languages (cpp, dotnet, golang, java, nodejs, php, python, rust) all use plain `FROM <image>` and resolve to the host's native architecture. Under Colima/Apple Silicon, the amd64 pin forces QEMU emulation, and gcc segfaults compiling the msgpack native gem during `bundle install` -- blocking local parametric runs against dd-trace-rb on arm64. The `ruby:3.2.1-bullseye` base image is multi-arch on Docker Hub, so this remains amd64 on CI (`ubuntu-latest` is amd64) and becomes arm64 on Apple Silicon dev machines -- matching the host-arch default already used by every other tracer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bm1549
added
ai-generated
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Ruby parametric Dockerfile is the only one in
utils/build/docker/with a--platform=linux/amd64pin on itsFROMline. Under Colima/Apple Silicon, the pin forces QEMU emulation, andgccsegfaults compiling themsgpacknative gem duringbundle install— blocking local parametric runs againstdd-trace-rbon arm64.Changes
Drop
--platform=linux/amd64fromutils/build/docker/ruby/parametric/Dockerfile. Theruby:3.2.1-bullseyebase image is multi-arch on Docker Hub, so this:ubuntu-latestis amd64), andThis was found while verifying a new laptop could run the full system-tests local-build flow for all nine tracer languages. Ruby was the only one that failed under Colima/arm64; with this change,
TEST_LIBRARY=ruby ./run.sh PARAMETRIC -k "test_start_span"passes against the localdd-trace-rbcheckout in ~26s.Note on host-arch divergence
A reviewer pointed out that this makes the Ruby parametric image's architecture depend on the build host — amd64 in CI, arm64 on Apple Silicon. That property already applies to every other parametric Dockerfile (none of them pin a platform), so this PR aligns Ruby with the existing convention rather than introducing new divergence. A separate, larger refactor would be needed to add explicit platform control to the parametric build path (see
utils/docker_fixtures/_test_clients/_core.py) — out of scope here.Workflow
Reviewer checklist
tests/ormanifests/is modified — touchesutils/build/docker/ruby/parametric/Dockerfile, will need R&P approvalbuild-ruby-imagelabel is set🤖 Generated with Claude Code