Summary
PR #81 added the cachedSKULookup helper for the Azure SKU catalogue. PR #97 extended common.ComputeDetails with VCPU + MemoryGB fields. The Azure compute converter at providers/azure/services/compute/client.go still doesn't populate them — it needs to call the helper (armcompute.ResourceSKUsClient.ListByLocation, cached per region) and pull vCPUs + MemoryGB from armcompute.ResourceSKU.Capabilities.
Current behaviour
convertAzureVMRecommendation populates only InstanceType in ComputeDetails. The new VCPU / MemoryGB fields ship as zero (omitted from JSON via omitempty).
Steps to verify the gap
Query a deployed environment with Azure compute recommendations, hit GET /api/recommendations, and observe that responses have details.vcpu and details.memory_gb absent (or zero) for compute recommendations.
Expected behaviour
Those fields populated from the SKU catalogue.
Proposed fix
In providers/azure/services/compute/client.go, mirror the cachedSKULookup pattern used by Cache/Cosmos/Database in PR #81. Look up vCPU / MemoryGB capabilities once per region, populate during convertAzureVMRecommendation. Graceful fallback to empty fields with a one-time WARN log on catalogue-fetch failure.
References
Severity
Low — UI degrades to "unknown" for vCPU/Memory on Azure compute recs; functional but loses resolution.
Effort
Small — one converter site, helper already exists post-#81.
Summary
PR #81 added the
cachedSKULookuphelper for the Azure SKU catalogue. PR #97 extendedcommon.ComputeDetailswithVCPU+MemoryGBfields. The Azure compute converter atproviders/azure/services/compute/client.gostill doesn't populate them — it needs to call the helper (armcompute.ResourceSKUsClient.ListByLocation, cached per region) and pullvCPUs+MemoryGBfromarmcompute.ResourceSKU.Capabilities.Current behaviour
convertAzureVMRecommendationpopulates onlyInstanceTypeinComputeDetails. The newVCPU/MemoryGBfields ship as zero (omitted from JSON viaomitempty).Steps to verify the gap
Query a deployed environment with Azure compute recommendations, hit
GET /api/recommendations, and observe that responses havedetails.vcpuanddetails.memory_gbabsent (or zero) for compute recommendations.Expected behaviour
Those fields populated from the SKU catalogue.
Proposed fix
In
providers/azure/services/compute/client.go, mirror thecachedSKULookuppattern used by Cache/Cosmos/Database in PR #81. Look up vCPU / MemoryGB capabilities once per region, populate duringconvertAzureVMRecommendation. Graceful fallback to empty fields with a one-time WARN log on catalogue-fetch failure.References
ComputeDetails.VCPU+MemoryGB)providers/azure/services/compute/client.go::convertAzureVMRecommendationpkg/common/types.go::ComputeDetailsSeverity
Low — UI degrades to "unknown" for vCPU/Memory on Azure compute recs; functional but loses resolution.
Effort
Small — one converter site, helper already exists post-#81.