Skip to content

Security fix breaks --link-dest via rsync daemon #915

@fufu65

Description

@fufu65

I usually perform backups via rsync daemon or to local disks, maintaining a history with hard links.
With the latest security backports in version 3.2.7 (3.2.7-0ubuntu0.22.04.6 on Ubuntu 22.04.5 LTS, 3.2.7-1ubuntu1.4 on Ubuntu 24.04.4 LTS), the --link-dest option does not work in daemon mode:

rsync -arAX --delete \
	--files-from="/path/to/files_to_add" -exclude-from="/path/to/exclude_patterns" \
	--link-dest="../01" "/" "rsync://USER@HOST:PORT/DEST/00/"

On the deamon host the "01" dir contains the last backup, while the "00" dir is initially empty.
No errors are reported; all files are simply transferred again... and after 2 backup cycles my backup disks are full :-(
In local mode this doesn't happen, and rsync still works correctly:

rsync -arAX --delete \
	--files-from="/path/to/files_to_add" -exclude-from="/path/to/exclude_patterns" \
	--link-dest="../01" "/" "/path_to_backup_dir/00/"

Downgrading the packages even just on the daemon host (3.2.7-0ubuntu0.22.04.4 on Ubuntu 22.04.5 LTS, 3.2.7-1ubuntu1.2 on Ubuntu 24.04.4 LTS) restores the correct behavior.
I have not had the opportunity to check other versions or systems.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions