fix: correct data errors in Tatooine static quest NPC tab files#413
fix: correct data errors in Tatooine static quest NPC tab files#413nicolassanchez02 wants to merge 3 commits into
Conversation
Four bugs found across the npc/static_quest data tables:
- rakir_banai.tab: fix typo 'objection/tangible/' -> 'object/tangible/'
in retrieve_object for the two fetch quest rows; the mission datadisk
path was invalid causing both quests to permanently fail item retrieval.
- kitster_banai.tab: fix objvar typo 'static.kister_banai' ->
'static.kitster_banai' in all five quest rows (missing 't'); also add
missing player_script and npc_script values to the smuggle quest row,
which had blank script columns causing the quest to never activate.
- tekil_barje.tab: remove 26 trailing blank/junk lines ('16 - Extras'
through '20 - Extras') that appeared after the three valid data rows;
these could interfere with row-count parsing in the framework.
- blerx_tango.tab: clear stale deliver_object value from the first
rescue quest row; rescue quests do not deliver objects and the
mission_datadisk.iff path here was leftover copy-paste data.
|
this one needs testing before merge |
|
Spinning up a local SWG test server, will follow up with test results. |
|
Pulled this onto the test server and ran through what I could before going in-game. Confirmed the bugs exist on master at the file level: the
Still need to go in-game and walk through the actual quest start/completion flow and verify the |
2 participants
Four data bugs in the
npc/static_questtab files for Tatooine NPCs. Pure data corrections, no logic changes.rakir_banai.tab:retrieve_objectpath readsobjection/tangible/mission/mission_datadisk.iffon both fetch quest rows. The leadingobjectionis a typo forobject. Both fetch quests (Silm'an Voueen and Wizzel) permanently fail because the path is invalid.kitster_banai.tab:overall_objvaris spelledstatic.kister_banai(missingt) across all five rows. The smuggle quest row (Thermal Det/slicer) also has blankplayer_scriptandnpc_scriptcolumns sonpc.static_questnever attaches and the quest can't start.tekil_barje.tab: 26 trailing lines after the three valid data rows, blank lines followed by rows labeled16 - Extrasthrough20 - Extras. Leftover template scaffolding. Could shift row-count parsing.blerx_tango.tab: First rescue quest row (Mixon Guncher/bith_sniper) hasdeliver_objectset toobject/tangible/mission/mission_datadisk.iff. Rescue quests don't deliver items, this is copy-paste residue.Closes #411