Skip to content

chore: deployment by name endpoint#1063

Merged
adityachoudhari26 merged 1 commit intomainfrom
deployment-by-name
Apr 24, 2026
Merged

chore: deployment by name endpoint#1063
adityachoudhari26 merged 1 commit intomainfrom
deployment-by-name

Conversation

@adityachoudhari26
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 22:06
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@adityachoudhari26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0474c8c-c4c5-4c4a-8e68-7cff67eb0ce2

📥 Commits

Reviewing files that changed from the base of the PR and between 8fd85f4 and 6759f69.

📒 Files selected for processing (5)
  • apps/api/openapi/openapi.json
  • apps/api/openapi/paths/deployments.jsonnet
  • apps/api/src/routes/v1/workspaces/deployments.ts
  • apps/api/src/types/openapi.ts
  • e2e/tests/api/deployments.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deployment-by-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Deployments API endpoint to fetch a deployment (including variables and systems) by its name within a workspace, and wires it through routing, OpenAPI, and E2E coverage.

Changes:

  • Add GET /v1/workspaces/{workspaceId}/deployments/name/{name} endpoint and handler.
  • Refactor shared “deployment with variables and systems” response construction to reuse between ID- and name-based getters.
  • Update OpenAPI (jsonnet + generated json + TS types) and add E2E tests for success + 404 cases.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
e2e/tests/api/deployments.spec.ts Adds E2E coverage for fetching a deployment by name and for missing-name 404 behavior.
apps/api/src/types/openapi.ts Extends generated OpenAPI TS types with the new path and getDeploymentByName operation.
apps/api/src/routes/v1/workspaces/deployments.ts Adds the new route + handler and factors out shared response-building logic.
apps/api/openapi/paths/deployments.jsonnet Declares the new OpenAPI path/operation for “get deployment by name”.
apps/api/openapi/openapi.json Updates generated OpenAPI JSON to include the new endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adityachoudhari26 adityachoudhari26 merged commit 451e4f6 into main Apr 24, 2026
13 checks passed
@adityachoudhari26 adityachoudhari26 deleted the deployment-by-name branch April 24, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants