chore: deployment by name endpoint#1063
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 55 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new Deployments API endpoint to fetch a deployment (including variables and systems) by its name within a workspace, and wires it through routing, OpenAPI, and E2E coverage.
Changes:
- Add
GET /v1/workspaces/{workspaceId}/deployments/name/{name}endpoint and handler. - Refactor shared “deployment with variables and systems” response construction to reuse between ID- and name-based getters.
- Update OpenAPI (jsonnet + generated json + TS types) and add E2E tests for success + 404 cases.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/tests/api/deployments.spec.ts | Adds E2E coverage for fetching a deployment by name and for missing-name 404 behavior. |
| apps/api/src/types/openapi.ts | Extends generated OpenAPI TS types with the new path and getDeploymentByName operation. |
| apps/api/src/routes/v1/workspaces/deployments.ts | Adds the new route + handler and factors out shared response-building logic. |
| apps/api/openapi/paths/deployments.jsonnet | Declares the new OpenAPI path/operation for “get deployment by name”. |
| apps/api/openapi/openapi.json | Updates generated OpenAPI JSON to include the new endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.