RunCommand to run one command at a time due to return size limitation

Author: adityagesh

lisa/features/non_ssh_executor.py

@@ -49,11 +49,11 @@ def _execute(self, commands: List[str]) -> List[str]:
             for command in commands:
                 serial_console.write(self._add_newline(command))
                 out.append(serial_console.read())
+            return out
         except Exception as e:
             raise LisaException(f"Failed to execute commands: {e}") from e
         finally:
             serial_console.close()
-        return out
 
     def _add_newline(self, command: str) -> str:
         """

lisa/node.py

@@ -743,7 +743,7 @@ def check_sudo_password_required(self) -> None:
                     raise RequireUserPasswordException("Reset password failed")
             self._check_password_and_store_prompt()
 
-    def _collect_logs_using_non_ssh_executor(self):
+    def _collect_logs_using_non_ssh_executor(self) -> None:
         """
         Collects information using the NonSshExecutor feature.
         This is used when the connection to the node is not stable.
@@ -764,9 +764,11 @@ def _collect_logs_using_non_ssh_executor(self):
 
         if self.features.is_supported(NonSshExecutor):
             non_ssh_executor = self.features[NonSshExecutor]
-            out = non_ssh_executor.execute(commands=commands)
-            out = "\n\n".join(out)
-            self.log.info(f"Collected information using NonSshExecutor:\n{out}")
+            outputs = non_ssh_executor.execute(commands=commands)
+            collected_info = "\n\n".join(outputs)
+            self.log.info(
+                f"Collected information using NonSshExecutor:\n{collected_info}"
+            )
         else:
             self.log.debug(
                 f"NonSshExecutor is not supported on {self.name}, "

lisa/sut_orchestrator/azure/features.py

@@ -3755,7 +3755,7 @@ def execute(self, commands: List[str]) -> str:
         :return: The output of the commands.
         """
         context = get_node_context(self._node)
-        platform = self._platform
+        platform: AzurePlatform = self._platform  # type: ignore
         compute_client = get_compute_client(platform)
 
         # Prepare the RunCommandInput for Azure
@@ -3772,7 +3772,7 @@ def execute(self, commands: List[str]) -> str:
         )
         result = wait_operation(operation=operation, failure_identity="run command")
 
-        return result["value"][0]["message"]
+        return str(result["value"][0]["message"])
 
     def _add_echo_before_command(self, commands: List[str]) -> List[str]:
         """
@@ -3784,10 +3784,14 @@ def _add_echo_before_command(self, commands: List[str]) -> List[str]:
 
 class NonSshExecutor(AzureFeatureMixin, features.NonSshExecutor):
     def execute(self, commands: List[str]) -> List[str]:
-        # RunCommand is faster than SerialConsole. Hence attempt to use it first.
+        # RunCommand does not require password login, hence attempt to use it first.
+        # RunCommand has a limitation on 4KB of output.
         try:
-            output = self._node.features[RunCommand].execute(commands)
-            return [output]
+            result = []
+            for command in commands:
+                out = self._node.features[RunCommand].execute([command])
+                result.append(out)
+            return result
         except Exception as e:
             self._log.info(f"RunCommand failed: {e}")
             # Fallback to the default non-SSH executor behavior