Skip to content

Set TFLint soft-fail: false in PR validation and main workflows #283

@WilliamBerryiii

Description

@WilliamBerryiii

Summary

The TFLint CI workflow was introduced in PR #229 with soft-fail: true in both pr-validation.yml and main.yml to allow initial rollout without blocking PRs. This issue tracks flipping to soft-fail: false so TFLint violations become enforced.

Current State

Workflow File soft-fail
PR Validation .github/workflows/pr-validation.yml (L146) true
Main .github/workflows/main.yml (L121) true
Reusable workflow default .github/workflows/terraform-lint.yml false

The reusable workflow already defaults to false — the callers explicitly override it to true.

Tasks

  • Fix all existing TFLint violations across infrastructure/terraform/
  • Set soft-fail: false in .github/workflows/pr-validation.yml
  • Set soft-fail: false in .github/workflows/main.yml
  • Verify CI passes on a test PR with hard-fail enabled

Context

Metadata

Metadata

Labels

enhancementNew feature or improvement request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions