feat(OBS-2873): add gRPC client keepalive configuration#90
Conversation
Extend shared channel options with keepalive time/timeout, permit pings without calls, and max_pings_without_data parity with netbox-assurance-plugin. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b23457faf1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex/Copilot review: OTLP exporters target arbitrary collectors; aggressive HTTP/2 keepalive can provoke GOAWAY on idle connections. Restrict keepalive plus max_pings_without_data to DiodeClient only; OTLP keeps user-agent-only options plus existing proxy/ssl behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
jajeffries
requested review from
MicahParks,
leoparente,
ltucker,
marc-barry and
mfiedorowicz
as code owners
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e0a8d4732
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reformat OTLP/ingester helper docstrings for D213/D403 and reorder test_client imports for I001. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Micah Parks <66095735+MicahParks@users.noreply.github.com>
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Summary
This change adds HTTP/2 keepalive channel options for
DiodeClient(ingester) so idle connections to the Diode API are less likely to be reset by intermediaries.DiodeOTLPClienttargets arbitrary OTLP collectors and therefore uses user-agent-only gRPC channel options (no keepalive /max_pings_without_data): many collectors enforce strict ping limits and canGOAWAYidle exporters otherwise.What changed
_diode_ingest_grpc_channel_options:grpc.primary_user_agentplusgrpc.keepalive_time_ms,grpc.keepalive_timeout_ms,grpc.keepalive_permit_without_calls, andgrpc.http2.max_pings_without_data(parity with netbox-assurance-plugin reconciler client where that stack talks to Diode-tolerant servers, ENGHLP-1220)._otlp_grpc_channel_options:grpc.primary_user_agentonly for OTLP.DiodeClientuses the ingester helper;DiodeOTLPClientuses the OTLP helper; proxy and SSL-related options are unchanged._diode_ingest_grpc_channel_optionsand assert OTLP channels exclude keepalive.How tested
pytest(full suite).