`BUILD_INTERPOLATION` and `BUILD_TEMPLATE` perform unnecessary refcount operations

[markshannon]

Feature or enhancement

Proposal:

BUILD_INTERPOLATION and BUILD_TEMPLATE call _PyInterpolation_Build and _PyTemplate_Build respectively, and then decref their arguments. All other BUILD instructions call a "steal" function, to avoid the unnecessary incref then decref. BUILD_INTERPOLATION and BUILD_TEMPLATE should do the same.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

• gh-145860: Eliminate unnecessary refcount operations in BUILD_INTERPOLATION and BUILD_TEMPLATE #148201

[akanil18]

Hi I would love to work on this issue.

I understand the goal is to optimize BUILD_INTERPOLATION and BUILD_TEMPLATE by using "steal" functions to avoid the unnecessary incref and decref operations, bringing them in line with how other BUILD instructions handle their arguments.

Could you please assign this issue to me, or let me know if it's okay for me to just go ahead and open a PR? Thanks

[sergey-miryanov]

I would suggest you wait answer from Mark before start doing this.