fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R) by Martinfx · Pull Request #1269 · ARM-software/ComputeLibrary

Martinfx · 2026-03-12T20:12:39Z

No description provided.

gunes-arm · 2026-03-16T12:58:04Z

Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately.

gunes-arm · 2026-03-16T13:00:57Z

@Martinfx I also suggest the following commit and pull request title:

fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)

Martinfx · 2026-03-16T13:04:22Z

Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately.

ok. no problem.

gunes-arm · 2026-03-16T15:34:14Z

@Martinfx clang-format hook in the pre-commit failed. You'll need to run that pre-commit hook.

src/common/cpuinfo/CpuInfo.cpp

Martinfx · 2026-03-25T08:04:54Z

@gunes-arm sysconf(_SC_NPROCESSORS_ONLN); is also FreeBSD and for OpenBSD. AT_NCPUS is not in OpenBSD elf_aux_info

Martinfx · 2026-03-29T14:12:49Z

Hi, @gunes-arm , it is ok ?

src/common/cpuinfo/CpuInfo.cpp

gunes-arm

Hi @Martinfx , thanks for your fixes. It looks good except a few minor things. You should also squash your commits.

src/common/cpuinfo/CpuInfo.cpp

gunes-arm

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

Martinfx · 2026-04-07T18:24:33Z

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

Yes. I reacted for comment: The problem with aarch64 is here #1274. Is amd64 support?

gunes-arm · 2026-04-08T15:59:01Z

src/common/cpuinfo/CpuInfo.cpp

I think we're inconsistent here. This elif will be chosen instead of what you implemented below. Therefore, we have to change this as

#elif defined(__arm__) && (defined(__OpenBSD__) || defined(__FreeBSD__))

This is for 32-bit build paths.

The comment next to it should be the previous if statement, i.e.

/* if !defined(_WIN64) && !defined(BARE_METAL) && !defined(__APPLE__) && !defined(__OpenBSD__) && !defined(__FreeBSD__) && !defined(__QNX__) && (defined(__arm__) || defined(__aarch64__)) */

gunes-arm · 2026-04-08T16:00:28Z

src/common/cpuinfo/CpuInfo.cpp

Here, the comment should be previous elif, i.e.

/* #elif defined(__arm__) && (defined(__OpenBSD__) || defined(__FreeBSD__)) */

src/common/cpuinfo/CpuInfo.cpp

gunes-arm · 2026-04-08T16:02:33Z

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

Yes. I reacted for comment: The problem with aarch64 is here #1274. Is amd64 support?

I replied in the issue. We do not support/test amd64 builds for anything other than Linux OS. I've posted a few more comments because what you implemented is being shadowed with the code above it.

Martinfx · 2026-04-08T20:45:36Z

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

Yes. I reacted for comment: The problem with aarch64 is here #1274. Is amd64 support?

I replied in the issue. We do not support/test amd64 builds for anything other than Linux OS. I've posted a few more comments because what you implemented is being shadowed with the code above it.

ok. thank you for response.

Signed-off-by: Martin Filla <freebsd@sysctl.cz>

gunes-arm

Thanks for making the changes @Martinfx. Here are my final comments. They're all about code comments, so, I'm going to trigger the CI.

gunes-arm · 2026-04-09T09:43:15Z

src/common/cpuinfo/CpuInfo.cpp

+#include <sys/types.h>
+#include <unistd.h>
+#endif /* #elif (defined(OpenBSD) || defined(FreeBSD)) && defined(aarch64) */
+#endif /* #elif (defined(__APPLE__)) && defined(__aarch64__) */


I think this one is for the outer if, therefore:
/* !defined(_WIN64) */

gunes-arm · 2026-04-09T09:43:47Z

src/common/cpuinfo/CpuInfo.cpp

 #include <sys/types.h>
-#endif /* defined(__APPLE__) && defined(__aarch64__)) */
-#endif /* !defined(BARE_METAL) && !defined(__APPLE__) && !defined(__OpenBSD__) && !defined(__FreeBSD__) && !defined(__QNX__) && (defined(__arm__) || defined(__aarch64__)) */
+#elif (defined(__OpenBSD__) || defined(__FreeBSD__)) && defined(__aarch64__)


This one should have /* #elif (defined(__APPLE__)) && defined(__aarch64__) */ next to it.

gunes-arm · 2026-04-09T09:45:11Z

src/common/cpuinfo/CpuInfo.cpp

 #include <asm/hwcap.h> /* Get HWCAP bits from asm/hwcap.h */
 #include <sys/auxv.h>
-#elif (defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__APPLE__)) && defined(__aarch64__)
+#elif (defined(__APPLE__)) && defined(__aarch64__)


This one should have

/* #if !defined(BARE_METAL) && !defined(__APPLE__) && !defined(__OpenBSD__) && !defined(__FreeBSD__) && \ !defined(__QNX__) && (defined(__arm__) || defined(__aarch64__)) */

next to it.

Part of it was already wrong before, so, I'm sorry for that but since we touch it, it'd be good to correct them.

Martinfx force-pushed the max-freeebsd-fix-ncpu branch from d90184d to 97df729 Compare March 16, 2026 13:02

Martinfx changed the title ~~fix: detect hw.ncpu for FreeBSD~~ fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R) Mar 16, 2026

gunes-arm requested changes Mar 16, 2026

View reviewed changes

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

Martinfx force-pushed the max-freeebsd-fix-ncpu branch from 5e831a8 to fad3d65 Compare March 24, 2026 17:55

Martinfx requested a review from gunes-arm March 24, 2026 17:57

Martinfx force-pushed the max-freeebsd-fix-ncpu branch 3 times, most recently from 2d8057c to bdadbf6 Compare March 24, 2026 18:26

gunes-arm reviewed Mar 30, 2026

View reviewed changes

src/common/cpuinfo/CpuInfo.cpp Show resolved Hide resolved

gunes-arm reviewed Mar 30, 2026

View reviewed changes

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

Martinfx requested a review from gunes-arm April 5, 2026 23:55

gunes-arm requested changes Apr 7, 2026

View reviewed changes

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

gunes-arm reviewed Apr 7, 2026

View reviewed changes

src/common/cpuinfo/CpuInfo.cpp Outdated Show resolved Hide resolved

Martinfx requested a review from gunes-arm April 7, 2026 18:08

Martinfx force-pushed the max-freeebsd-fix-ncpu branch from 20a4498 to d9f0a9c Compare April 7, 2026 18:12

gunes-arm requested changes Apr 7, 2026

View reviewed changes

gunes-arm requested changes Apr 8, 2026

View reviewed changes

fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)

e6ab46d

Signed-off-by: Martin Filla <freebsd@sysctl.cz>

Martinfx force-pushed the max-freeebsd-fix-ncpu branch from 70853b4 to e6ab46d Compare April 8, 2026 20:50

Martinfx requested a review from gunes-arm April 8, 2026 20:50

gunes-arm requested changes Apr 9, 2026

View reviewed changes

Conversation

Martinfx commented Mar 12, 2026

Uh oh!

gunes-arm commented Mar 16, 2026

Uh oh!

gunes-arm commented Mar 16, 2026

Uh oh!

Martinfx commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gunes-arm commented Mar 16, 2026

Uh oh!

Uh oh!

Martinfx commented Mar 25, 2026

Uh oh!

Martinfx commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

gunes-arm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunes-arm left a comment

Choose a reason for hiding this comment

Uh oh!

Martinfx commented Apr 7, 2026

Uh oh!

gunes-arm Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

gunes-arm Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gunes-arm commented Apr 8, 2026

Uh oh!

Martinfx commented Apr 8, 2026

Uh oh!

gunes-arm left a comment

Choose a reason for hiding this comment

Uh oh!

gunes-arm Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gunes-arm Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gunes-arm Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Martinfx commented Mar 16, 2026 •

edited

Loading