[PWGHF] HFInvMassFitter enhancement#15860
Draft
lubynets wants to merge 26 commits intoAliceO2Group:masterfrom
Draft
[PWGHF] HFInvMassFitter enhancement#15860lubynets wants to merge 26 commits intoAliceO2Group:masterfrom
lubynets wants to merge 26 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 0 errors, |
Contributor
Author
|
All checks except for O2Physics build are passed. Since this PR does not affect files compiled within O2Physics, the pending test do not make sense for it, therefore the PR is converted to draft to prevent the server from unnecessary job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed explanation: it was observed that the raw yield as a function of BDT NP score lower-value cut demonstrates non-smooth behavior (see some outlier points in left panel as well as points with error bars larger than the neighbor points have). It was assumed to happen due to possible fit's convergence to a local minimum instead of the global one exactly at this NP score cut. In order to avoid this, the initial fit parameters are now randomized around their original values, using the
TRandom3class seeded withRandomSeedconfigurable. It turns out that for 100 trials most of raw yield values clusterize at a certain value (which is belived to be a "true" value), wile some number of outliers is present (middle panel). The median out of 100 trials value of each variable of interest (raw yield, mean, sigma, or statistical error on them) can be extracted, then the raw yield vs NP score cut distribution does not have outliers (right panel). This is critically important for stability of the cut variation method implemented in cut_variation.py.Added double-sided Crystal Ball function to possible signal functions.
Configuration via json made more user- and reading-friendly:
vector of values (of the size of number of slice intervals) can be replaced with a single number when all vector components are equal;
check for correct parsing the config added (to replace the json package error message with the custom one);
histograms which are optional in some mode (e.g. MC) are not requested to be present in the config.
Bugs and code imperfections cleaned