[PWGLF] Added separate work flow for lamda analysis in pO system.#15875
Closed
bhattdurgesh921-sys wants to merge 0 commit intoAliceO2Group:masterfrom
Closed
[PWGLF] Added separate work flow for lamda analysis in pO system.#15875bhattdurgesh921-sys wants to merge 0 commit intoAliceO2Group:masterfrom
bhattdurgesh921-sys wants to merge 0 commit intoAliceO2Group:masterfrom
Conversation
bhattdurgesh921-sys
requested review from
alibuild,
dmallick2,
mpuccio,
omvazque,
prottayCMT,
skundu692 and
smaff92
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 76 errors, |
This was referenced Apr 20, 2026
vkucera
reviewed
Apr 20, 2026
Comment on lines
+49
to
+57
| namespace lambda_analysis { | ||
| // Named PDG codes — fixes pdg/explicit-code and magic-number errors | ||
| static constexpr int PdgProton{2212}; | ||
| static constexpr int PdgKaon{321}; | ||
| static constexpr int PdgLambda0{3122}; | ||
| static constexpr int PdgXiMinus{3312}; | ||
| static constexpr int PdgXi0{3322}; | ||
| static constexpr int PdgOmegaMinus{3334}; | ||
| } // namespace lambda_analysis |
Collaborator
There was a problem hiding this comment.
No, this is not how you fix the pdg/explicit-code and magic-number errors. Did you actually read the error messages?
vkucera
reviewed
Apr 20, 2026
Comment on lines
+73
to
+78
| // FIX name/configurable: lowerCamelCase, member name == JSON string, on one | ||
| // line | ||
| Configurable<bool> applyOccupancyInTimeRangeCut{ | ||
| "applyOccupancyInTimeRangeCut", false, | ||
| "If true, apply a cut on the number of tracks in a time window around " | ||
| "the collision (occupancy cut)"}; |
Collaborator
There was a problem hiding this comment.
Why are you doing the exact opposite?
bhattdurgesh921-sys
force-pushed
the
master
branch
from
80e85e4 to
f19bdb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added separate work flow for lamda analysis in pO system.