feat: #1224 framework wide UI font scaling and per area scale override#1479
Open
funkosaur wants to merge 1 commit into
Open
feat: #1224 framework wide UI font scaling and per area scale override#1479funkosaur wants to merge 1 commit into
funkosaur wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the small-text concern raised in discussion #1224 . Made the existing
fontSizeScaleUIsetting actually framework-wide, and introduced three optional per-area scales on top so menus, dialogs, and notifications can each be tuned independently without affecting the rest of the UI.Changes
fontSizeScaleUIapplication intoFXGLUIFactoryServiceProviderat the single font-construction chokepoint, so every piece of UI routed throughgetUIFactoryService()now scales: menus, buttons, mini-games, dev console, inventory, cutscenes, loading screen, plus user code that uses the factory.GameSettings, each defaulting to1.0and multiplied on top offontSizeScaleUI:fontSizeScaleMenufontSizeScaleDialogfontSizeScaleNotificationfontSizeScaleDialogintoFXGLDialogFactoryServiceProvider.fontSizeScaleNotificationintoNotificationServiceProvider, alongside the existingfontSizeScaleUIinjection, both are applied because the notification view bypassesUIFactoryService.fontSize: Doublefield toNotificationViewand switchedXboxNotificationViewfrom hardcodedFont.font(18.0)toFont.font(fontSize)insideplayInAnimation().menuScalecomputed property toFXGLDefaultMenureadinggetSettings().fontSizeScaleMenu.effective_size = raw * fontSizeScaleUI * fontSizeScaleArea.Backward-compatible: all new fields default to
1.0. Existing user code that only touchesfontSizeScaleUIcontinues to work; what changes is thatfontSizeScaleUInow affects more UI than it used to.