Skip to content

Rename MemorySegment to DataSegment in definitions #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MaxGraey wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

Rename MemorySegment to DataSegment in definitions #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,8 +1824,8 @@ declare module binaryen {
getExport(externalName: string): ExportRef;
getNumExports(): number;
getExportByIndex(index: number): ExportRef;
setMemory(initial: number, maximum: number, exportName?: string | null, segments?: MemorySegment[] | null, shared?: boolean, memory64?: boolean, internalName?: string): void;
getMemorySegmentInfo(name: string): MemorySegmentInfo;
setMemory(initial: number, maximum: number, exportName?: string | null, segments?: DataSegment[] | null, shared?: boolean, memory64?: boolean, internalName?: string): void;
getDataSegmentInfo(name: string): DataSegmentInfo;
getStart(): FunctionRef;
setStart(start: FunctionRef): void;
getFeatures(): Features;
Expand All @@ -1837,7 +1837,7 @@ declare module binaryen {
getNumTables(): number;
hasMemory(): boolean;
getMemoryInfo(name?: string): MemoryInfo;
getNumMemorySegments(): number;
getNumDataSegments(): number;
getNumElementSegments(): number;
getGlobalByIndex(index: number): GlobalRef;
getTableByIndex(index: number): TableRef;
Expand Down Expand Up @@ -1885,7 +1885,7 @@ declare module binaryen {
buildAndDispose(): HeapType[];
}

interface MemorySegment {
interface DataSegment {
offset: ExpressionRef;
data: Uint8Array;
passive?: boolean;
Expand All @@ -1902,7 +1902,7 @@ declare module binaryen {
function getExpressionType(expression: ExpressionRef): Type;
function getExpressionInfo(expression: ExpressionRef): ExpressionInfo;

interface MemorySegmentInfo {
interface DataSegmentInfo {
offset: ExpressionRef;
data: Uint8Array;
passive: boolean;
Expand Down