fix(cse): resolve error code collisions and add missing definition#8241
Open
fix(cse): resolve error code collisions and add missing definition#8241
Conversation
- Change `ERR_PULL_POD_INFRA_CONTAINER_IMAGE` from `225` to `233` to avoid collision with `ERR_NVIDIA_GPG_KEY_DOWNLOAD_TIMEOUT` - Change `ERR_IMDS_FETCH_FAILED` from `231` to `234` to avoid collision with `ERR_ORAS_PULL_SYSEXT_FAIL` - Add missing `ERR_NVIDIA_DCGM_INSTALL=235` definition used by `cse_config.sh` Fixes #7466, fixes #7467 Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
surajssd
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Linux CSE helper error code definitions to eliminate numeric collisions and adds a missing error code constant so provisioning failures can be distinguished reliably.
Changes:
- Reassign
ERR_PULL_POD_INFRA_CONTAINER_IMAGEfrom225to233to avoid colliding withERR_NVIDIA_GPG_KEY_DOWNLOAD_TIMEOUT=225. - Reassign
ERR_IMDS_FETCH_FAILEDfrom231to234to avoid colliding withERR_ORAS_PULL_SYSEXT_FAIL=231. - Add missing
ERR_NVIDIA_DCGM_INSTALL=235definition (used by managed GPU experience install path).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes CSE error code collisions and a missing error code definition in
parts/linux/cloud-init/artifacts/cse_helpers.sh.Two pairs of error codes shared the same numeric value, which makes it impossible to distinguish between different failure modes during node provisioning. Additionally,
ERR_NVIDIA_DCGM_INSTALLwas used incse_config.shbut never defined, meaning it would resolve to an empty string at runtime.Changes
ERR_PULL_POD_INFRA_CONTAINER_IMAGE:225->233(previously collided withERR_NVIDIA_GPG_KEY_DOWNLOAD_TIMEOUT=225)ERR_IMDS_FETCH_FAILED:231->234(previously collided withERR_ORAS_PULL_SYSEXT_FAIL=231)ERR_NVIDIA_DCGM_INSTALL=235: added missing definition (used byinstallNvidiaManagedExpPkgFromCacheincse_config.sh)Which issue(s) this PR fixes:
Fixes #7466
Fixes #7467