Skip to content

JOBSS - BYOL#521

Merged
btardif merged 5 commits intomasterfrom
bk-jboss-byol
Aug 22, 2025
Merged

JOBSS - BYOL#521
btardif merged 5 commits intomasterfrom
bk-jboss-byol

Conversation

@btardif
Copy link
Copy Markdown
Member

@btardif btardif commented Aug 11, 2025

Summary

@edburns
Copy link
Copy Markdown
Member

edburns commented Aug 11, 2025

Yes, please add me as a reviewer.

@github-actions
Copy link
Copy Markdown

Preview link: https://antares-blog-staging-pr-521.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview site shows any future-dated articles. If you are publishing a future-dated article, it will not show on the production site until the file's specified date.
  • The preview link is shareable, but will be deleted when this pull request is merged or closed.

This is an automated message.

@btardif btardif requested a review from edburns August 11, 2025 18:24
@@ -0,0 +1,36 @@
# 🚀 Bring Your Own License (BYOL) Support for JBOSS EAP on Azure App Service
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me but I think we need to rename the file to use the proper capitalization. The name is "JBoss" (only capital J and capital B).

Please use "JBoss" in this title.

In the preview, there is a heading/title that also has the wrong capitalization ("Byol Support For Jboss"), it should probably be "BYOL support for JBoss".

image

Copy link
Copy Markdown
Member Author

@btardif btardif Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed this on the file-name and the title, first heading, but still need to figure out to fix it for the title

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After GTM meeting on Monday 2025-08-11, we want to get the following message near the top:

  • If you took a look in the past, take another look. We fixed it.

@btardif btardif marked this pull request as ready for review August 20, 2025 22:52
@btardif
Copy link
Copy Markdown
Member Author

btardif commented Aug 20, 2025

@edburns / @dfuenzalida fixed the last casing issue I had in the title, I plan to merge this by Friday for it to go live on Monday unless I hear otherwise.

@btardif btardif merged commit a78a57c into master Aug 22, 2025
4 checks passed
@btardif btardif deleted the bk-jboss-byol branch August 22, 2025 17:43
@btardif
Copy link
Copy Markdown
Member Author

btardif commented Aug 22, 2025

@edburns this is now merged and will go live on monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants