Skip to content

update az monitor assignment and storage account definitions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taoyangcloud merged 4 commits into from
Apr 4, 2026
Merged

update az monitor assignment and storage account definitions #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5dbfa43
Add microsoft.com to allowed email domains for Azure Monitor policies
taoyangcloud Apr 4, 2026
a2e3c67
Remove application tag restrictions from storage account policies
taoyangcloud Apr 4, 2026
2e1f110
Remove deprecated pipeline template deployment script from integratio…
taoyangcloud Apr 4, 2026
0e597ff
Enhance verbose logging in policy integration test case retrieval
taoyangcloud Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion policyAssignments/dev/pa-d-monitor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
},
"MON-001_allowedEmailDomains": {
"value": [
"contoso.com"
"contoso.com",
"microsoft.com"
]
},
"MON-002_Effect": {
Expand Down
3 changes: 2 additions & 1 deletion policyAssignments/prod/pa-p-monitor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
},
"MON-001_allowedEmailDomains": {
"value": [
"contoso.com"
"contoso.com",
"microsoft.com"
]
},
"MON-002_Effect": {
Expand Down
12 changes: 0 additions & 12 deletions policyDefinitions/storage-account/pol-deny-storage-account-public-endpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,6 @@
"field": "type",
"equals": "Microsoft.Storage/storageAccounts"
},
{
"not": {
"field": "tags[application]",
"equals": "databricks"
}
},
{
"not": {
"field": "tags[application]",
"equals": "purview"
}
},
{
"anyOf": [
{
Expand Down
12 changes: 0 additions & 12 deletions ...yDefinitions/storage-account/pol-deny-storage-account-restrict-virtual-network-rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@
"field": "type",
"equals": "Microsoft.Storage/storageAccounts"
},
{
"not": {
"field": "tags[application]",
"equals": "databricks"
}
},
{
"not": {
"field": "tags[application]",
"equals": "purview"
}
},
{
"anyOf": [
{
Expand Down
12 changes: 0 additions & 12 deletions ...Definitions/storage-account/pol-deny-storage-accounts-should-restrict-network-access.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@
"field": "type",
"equals": "Microsoft.Storage/storageAccounts"
},
{
"not": {
"field": "tags[application]",
"equals": "databricks"
}
},
{
"not": {
"field": "tags[application]",
"equals": "purview"
}
},
{
"field": "Microsoft.Storage/storageAccounts/networkAcls.defaultAction",
"notEquals": "Deny"
Expand Down
12 changes: 0 additions & 12 deletions policyDefinitions/storage-account/pol-deploy-storage-account-blob-soft-delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,6 @@
"field": "type",
"equals": "Microsoft.Storage/storageAccounts"
},
{
"not": {
"field": "tags[application]",
"equals": "databricks"
}
},
{
"not": {
"field": "tags[application]",
"equals": "purview"
}
},
{
"field": "kind",
"in": [
Expand Down
5 changes: 3 additions & 2 deletions scripts/pipelines/policy-integration-tests/pipeline-map-policy-integration-test-cases.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,11 @@ function getTestCasesFromAssignment {
[string]$policyIntegrationTestsPath
)
$testsInScope = @()
$testCases = Get-ChildItem -path $policyIntegrationTestsPath -Depth 1 -Directory
Write-Verbose " - Looking for test cases that are impacted by the policy assignment '$assignmentName' from '$policyIntegrationTestsPath'." -Verbose
$testCases = Get-ChildItem -path $policyIntegrationTestsPath -Depth 0 -Directory

foreach ($testCase in $testCases) {
Write-Verbose " - Checking test case '$($testCase.Name)' for assignment '$assignmentName'..." -Verbose
$testConfigFile = join-Path -Path $testCase.FullName -ChildPath 'config.json' -Resolve
$testConfig = Get-Content -Path $testConfigFile -Raw | ConvertFrom-Json -Depth 99
$policyAssignmentIds = $testConfig.policyAssignmentIds
Expand Down Expand Up @@ -523,7 +525,6 @@ Foreach ($file in $modifiedFiles) {
Write-Verbose " - File '$file' is not in the global test paths. Will Check if individual tests need to be executed." -Verbose
$getRequiredTestCasesParams = @{
changeFilePath = $file
policyIntegrationTestsPath = $policyIntegrationTestsPath
policyInitiativesPath = $policyInitiativesPath
policyAssignmentsPath = $policyAssignmentsPath
gitRoot = $gitRoot
Expand Down
1 change: 0 additions & 1 deletion tests/policy-integration-tests/.shared/policy_integration_test_config.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@
"scripts/pipelines/pipeline-get-deployment-target-from-parameter-file.ps1",
"scripts/pipelines/pipeline-get-parameter-files.ps1",
"scripts/pipelines/pipeline-install-moduleFromRepo.ps1",
"scripts/pipelines/pipeline-template-deployment.ps1",
"scripts/pipelines/pipeline-template-deployment-rest.ps1",
"scripts/pipelines/pipeline-template-validation.ps1",
"scripts/pipelines/pipeline-set-policy-resource-bicep-template-file.ps1",
Expand Down