Skip to content

ThroughputBucketing: Adds Throughput Bucket to RequestOptions and ClientOptions#4940

Merged
kirankumarkolli merged 14 commits intomasterfrom
users/acagrawal/throughputBucketing/addRequestOptions
Jan 8, 2025
Merged

ThroughputBucketing: Adds Throughput Bucket to RequestOptions and ClientOptions#4940
kirankumarkolli merged 14 commits intomasterfrom
users/acagrawal/throughputBucketing/addRequestOptions

Conversation

@Achint-Agrawal
Copy link
Copy Markdown
Contributor

@Achint-Agrawal Achint-Agrawal commented Dec 27, 2024

Description

This PR add ThroughputBucket in RequestOptions and ClientOptions to support Throughput Bucketing

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@Achint-Agrawal Achint-Agrawal changed the title Added Throughput Bucket to RequestOptions and ClientOptions [Internal] Category:Adds Added Throughput Bucket to RequestOptions and ClientOptions Dec 27, 2024
@Achint-Agrawal Achint-Agrawal changed the title [Internal] Category:Adds Added Throughput Bucket to RequestOptions and ClientOptions [Internal] Category:Adds Throughput Bucket to RequestOptions and ClientOptions Dec 27, 2024
@Achint-Agrawal Achint-Agrawal changed the title [Internal] Category:Adds Throughput Bucket to RequestOptions and ClientOptions ThroughputBucketing:Adds Throughput Bucket to RequestOptions and ClientOptions Dec 27, 2024
@Achint-Agrawal Achint-Agrawal changed the title ThroughputBucketing:Adds Throughput Bucket to RequestOptions and ClientOptions ThroughputBucketing: Adds Throughput Bucket to RequestOptions and ClientOptions Dec 27, 2024
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - overall changes look good. Mainly blocking on clarification for versioning/rollout/onboarding.

Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@Achint-Agrawal Achint-Agrawal requested a review from a team as a code owner January 5, 2025 14:12
Copy link
Copy Markdown
Contributor

@sourabh1007 sourabh1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirankumarkolli kirankumarkolli merged commit 76f0e7b into master Jan 8, 2025
@kirankumarkolli kirankumarkolli deleted the users/acagrawal/throughputBucketing/addRequestOptions branch January 8, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants