Draft
Conversation
….java for CI compliance
This reverts commit fbd62ca.
- Add find-package-skill registry at .github/skills/ (matches JS/Python/.NET pattern) - Fix search SKILL.md: add breaking change detection (Phase 3.6), import cleanup (Phase 3.7), test recording guidance (Phase 4), structured changelog format (Phase 5) - Fix search SKILL.md: rename to search-documents, improve trigger phrases - Fix search SKILL.md: add error categorization guidance (generated vs hand-written files) - Remove .NET comparison section from customizations.md (cross-language pollution) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
- Phase 3.5: Add dedup guard for includeOldApiVersions() — prevents duplicate enum constants when generator produces a version that was previously only in the customization list - Phase 3: Add accept-header type renumbering guidance (CreateOrUpdateRequestAccept* types change numbers between spec versions) - Customizations.md: Update includeOldApiVersions() code example with existence check and .toUpperCase() fix Eval: mock_search_2026-05-01-preview produced 18 build errors. These fixes address 2 of the 3 root causes found. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Root cause analysis showed the import errors are NOT from type renumbering — they're from hideWithResponseBinaryDataApis() customization creating cross-package references. Updated Phase 3 guidance to point agent to SearchCustomizations.java instead of suggesting manual import edits on generated files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skill fixes based on eval where with-skill agent performed worse on 2 of 3 errors: 1. SKILL.md: Add 'Common Pitfalls' section (Maor's one-pager pattern) calling out the 5 most dangerous mistakes upfront 2. SKILL.md Phase 3: Add error categorization table with 3 categories and explicit 'check SearchCustomizations.java FIRST' directive 3. SKILL.md Phase 3.5: Reframe from 'add versions' to 'verify and remove duplicates' 4. architecture.md: Add @generated annotation guidance — explains that generated files contain both @generated (auto-updated) and non-@generated (hand-written, needs manual update) methods 5. SKILL.md description: Use semicolons for trigger phrases (Maor's YAML convention) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.