-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Key Vault Certificates] Remove preview service version from GA library #48678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitsinghal4u
wants to merge
10
commits into
main
Choose a base branch
from
fix/keyvault-certificates-stabilize-490
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
57dec85
[Key Vault Certificates] Remove preview service version from GA library
singhalrohit4u e22dc02
Revert getLatest() to V7_6 to fix playback test failures
singhalrohit4u 37c1da6
Remove 2025-06-01-preview from customization version list
singhalrohit4u 0f0d8a1
Merge branch 'main' into fix/keyvault-certificates-stabilize-490
rohitsinghal4u e0ae632
Update CertificateServiceVersion.getLatest() to V2025_07_01 and re-re…
singhalrohit4u 907e434
Merge branch 'main' into fix/keyvault-certificates-stabilize-490
rohitsinghal4u d7b5674
Re-record CertificateAsyncClientTest against live 2025-07-01 API
singhalrohit4u 65cc090
Re-record mergeCertificate tests with JDK 8 for api-version 2025-07-01
singhalrohit4u 07177dd
Retrigger CI
singhalrohit4u 7cb6ba4
Merge branch 'main' into fix/keyvault-certificates-stabilize-490
rohitsinghal4u File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any APIs generated from this preview version that should be removed too? This change only removes the preview version from the enum but doesn't remove any of the APIs (if there are any) from this version. Please verify that we are not shipping any features that are still in preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uris and ipAddresses properties on SubjectAlternativeNames were introduced with @Versioning.added(v2025_06_01_preview) in the TypeSpec spec, but since v2025_07_01 is a later stable version in the Versions enum, those properties are also part of the 2025-07-01 stable API surface. No APIs need to be removed — everything currently in the library and its CHANGELOG corresponds to the stable 2025-07-01 API.