Draft
Conversation
…to mgmt-release-guidance.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ommand, and test skip guidance (#37846) Applies review feedback to `sdk-release-agent.md` — four targeted corrections to the agent prompt. ### Changes - **MCP tool name** (line 41): Removed hard-coded `github-mcp-server-get_job_logs` function name; replaced with generic "use the GitHub MCP Actions toolset" to avoid brittleness on tool renames. - **Workflow marker** (line 63): Fixed stable dedup marker from `mgmt-release-agent` → `sdk-release-agent` to match actual workflow identity. - **Build command** (line 72): Changed `pnpm build --filter ...${package_name}...` → `pnpm turbo build --filter=<package-name>... --token 1`, matching repo-standard Turbo invocation. - **UnitTest skip guidance** (lines 84–85): Rewritten to prioritize updating recordings as the primary fix; scoped test-skipping as a last resort requiring explicit justification and SDK maintainer approval. ### Packages impacted by this PR `.github/workflows/sdk-release-agent.md` (workflow prompt only — no SDK package code changed) ### Issues associated with this PR N/A (review feedback followup) ### Describe the problem that is addressed by this PR The agent prompt contained a hard-coded MCP tool function name (fragile to renames), a wrong workflow ID in the dedup marker, a non-standard build command that would mislead contributors, and UnitTest failure guidance that normalized skipping tests as a first-class fix. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Direct in-place corrections — no structural changes to the workflow or lock file needed. ### Are there test cases added in this PR? _(If not, why?)_ No — changes are to a markdown agent prompt; no executable code modified. ### Provide a list of related PRs _(if any)_ Parent PR introducing `sdk-release-agent`: #37824 ### Checklists - [ ] Added impacted package name to the issue description. - [ ] Does this PR need any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here.)_ - [ ] Added a changelog (if necessary). <!-- START COPILOT CODING AGENT TIPS --> --- 📱 Kick off Copilot coding agent tasks wherever you are with [GitHub Mobile](https://gh.io/cca-mobile-docs), available on iOS and Android. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MaryGao <9943211+MaryGao@users.noreply.github.com>
…e.md # Conflicts: # .github/CODEOWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mgmt release guidance.md