[AutoPR @azure-arm-computelimit]-generated-from-SDK Generation - JS-6087534#37913
Open
[AutoPR @azure-arm-computelimit]-generated-from-SDK Generation - JS-6087534#37913
Conversation
…t.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'a83147fe12aece4ded0bd96be212e5242e087cb9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087534 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…t.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'cca5b9fb049544c3bd14869f1642d4cc0187ef00' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087782 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
kazrael2119
added
Mgmt
kazrael2119
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng and
qiaozha
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates @azure/arm-computelimit to the stable 1.0.0 SDK generated from the ComputeLimit TypeSpec config targeting API version 2026-03-20, including a new features operation group and updated helpers for paging/LRO.
Changes:
- Adds Features APIs (enable/get/list) plus new models (
Feature,OperationStatusResult) and wires them intoComputeLimitClient. - Updates paging + LRO polling helpers to ensure
api-versionis preserved/appended fornextLinkand polling URLs. - Moves package + samples from beta to stable (version bumps, new v1 samples, updated docs/exports).
Reviewed changes
Copilot reviewed 71 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/computelimit/arm-computelimit/warp.config.yml | Adds features export and target polyfill suffixes for warp builds. |
| sdk/computelimit/arm-computelimit/tsp-location.yaml | Updates spec repo commit pin for generation input. |
| sdk/computelimit/arm-computelimit/src/static-helpers/urlTemplate.ts | Normalizes expanded URL templates to avoid %2D artifacts (e.g. api%2Dversion). |
| sdk/computelimit/arm-computelimit/src/static-helpers/pollingHelpers.ts | Adds LRO polling helper that can append api-version to poll URLs when missing. |
| sdk/computelimit/arm-computelimit/src/static-helpers/pagingHelpers.ts | Extends paging helper to support POST nextLinks and appending api-version to nextLinks. |
| sdk/computelimit/arm-computelimit/src/restorePollerHelpers.ts | Adds restorePoller helper for resuming LROs from serialized state. |
| sdk/computelimit/arm-computelimit/src/models/models.ts | Adds Feature + OperationStatusResult models and new KnownVersions entry. |
| sdk/computelimit/arm-computelimit/src/models/index.ts | Re-exports new models and KnownFeatureState. |
| sdk/computelimit/arm-computelimit/src/index.ts | Exposes features APIs/types and restorePoller from the package surface. |
| sdk/computelimit/arm-computelimit/src/computeLimitClient.ts | Adds client.features operation group. |
| sdk/computelimit/arm-computelimit/src/classic/index.ts | Exports FeaturesOperations type. |
| sdk/computelimit/arm-computelimit/src/classic/features/index.ts | New classic wrapper for Features operations. |
| sdk/computelimit/arm-computelimit/src/api/sharedLimits/operations.ts | Defaults api-version to 2026-03-20 and passes apiVersion into paging helper. |
| sdk/computelimit/arm-computelimit/src/api/sharedLimits/index.ts | Adjusts type re-exports formatting. |
| sdk/computelimit/arm-computelimit/src/api/operations/operations.ts | Defaults api-version to 2026-03-20 and passes apiVersion into paging helper. |
| sdk/computelimit/arm-computelimit/src/api/operations/index.ts | Adjusts type re-exports formatting. |
| sdk/computelimit/arm-computelimit/src/api/index.ts | Splits value export (createComputeLimit) from type exports. |
| sdk/computelimit/arm-computelimit/src/api/guestSubscriptions/operations.ts | Defaults api-version to 2026-03-20 and passes apiVersion into paging helper. |
| sdk/computelimit/arm-computelimit/src/api/guestSubscriptions/index.ts | Adjusts type re-exports formatting. |
| sdk/computelimit/arm-computelimit/src/api/features/options.ts | New options types for Features operations (includes LRO polling interval). |
| sdk/computelimit/arm-computelimit/src/api/features/operations.ts | New Features REST operations (enable LRO, list paging, get). |
| sdk/computelimit/arm-computelimit/src/api/features/index.ts | Exports Features operations + options. |
| sdk/computelimit/arm-computelimit/src/api/computeLimitContext.ts | Makes apiVersion optional and aligns UA string with stable version. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/tsconfig.json | Adds v1 TypeScript samples tsconfig. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/sharedLimitsListBySubscriptionLocationResourceSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/sharedLimitsGetSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/sharedLimitsDeleteSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/sharedLimitsCreateSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/operationsListSample.ts | Updates sample metadata + fixes subscriptionId placeholder length. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/guestSubscriptionsListBySubscriptionLocationResourceSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/guestSubscriptionsGetSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/guestSubscriptionsDeleteSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/guestSubscriptionsCreateSample.ts | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/featuresListBySubscriptionLocationResourceSample.ts | New v1 Features list sample. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/featuresGetSample.ts | New v1 Features get sample (two variants). |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/src/featuresEnableSample.ts | New v1 Features enable (LRO) sample. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/sample.env | Adds v1 TypeScript sample env placeholder file. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/README.md | Updates samples README for v1 + adds Features samples. |
| sdk/computelimit/arm-computelimit/samples/v1/typescript/package.json | Moves samples package from beta naming to stable; uses latest dependency. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/sharedLimitsListBySubscriptionLocationResourceSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/sharedLimitsGetSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/sharedLimitsDeleteSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/sharedLimitsCreateSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/sample.env | Adds v1 JavaScript sample env placeholder file. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/README.md | Updates samples README for v1 + adds Features samples. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/package.json | Moves samples package from beta naming to stable; uses latest dependency. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/operationsListSample.js | Updates sample metadata + fixes subscriptionId placeholder length. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/guestSubscriptionsListBySubscriptionLocationResourceSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/guestSubscriptionsGetSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/guestSubscriptionsDeleteSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/guestSubscriptionsCreateSample.js | Updates sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/featuresListBySubscriptionLocationResourceSample.js | New v1 Features list sample. |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/featuresGetSample.js | New v1 Features get sample (two variants). |
| sdk/computelimit/arm-computelimit/samples/v1/javascript/featuresEnableSample.js | New v1 Features enable (LRO) sample. |
| sdk/computelimit/arm-computelimit/samples-dev/sharedLimitsListBySubscriptionLocationResourceSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/sharedLimitsGetSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/sharedLimitsDeleteSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/sharedLimitsCreateSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/operationsListSample.ts | Updates dev sample metadata + fixes subscriptionId placeholder length. |
| sdk/computelimit/arm-computelimit/samples-dev/guestSubscriptionsListBySubscriptionLocationResourceSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/guestSubscriptionsGetSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/guestSubscriptionsDeleteSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/guestSubscriptionsCreateSample.ts | Updates dev sample metadata to 2026-03-20. |
| sdk/computelimit/arm-computelimit/samples-dev/featuresListBySubscriptionLocationResourceSample.ts | New dev Features list sample. |
| sdk/computelimit/arm-computelimit/samples-dev/featuresGetSample.ts | New dev Features get sample. |
| sdk/computelimit/arm-computelimit/samples-dev/featuresEnableSample.ts | New dev Features enable sample. |
| sdk/computelimit/arm-computelimit/review/arm-computelimit-node.api.md | API report updates for stable release + new features/restorePoller surface. |
| sdk/computelimit/arm-computelimit/review/arm-computelimit-models-node.api.md | API report updates for new models/enums/versions. |
| sdk/computelimit/arm-computelimit/review/arm-computelimit-api-node.api.md | API report updates for ComputeLimitContext apiVersion optionality. |
| sdk/computelimit/arm-computelimit/review/arm-computelimit-api-features-node.api.md | New API report for features subpath. |
| sdk/computelimit/arm-computelimit/README.md | Updates API reference URL to stable docs. |
| sdk/computelimit/arm-computelimit/package.json | Bumps to 1.0.0, adds deps for LRO + abort controller, exports ./api/features. |
| sdk/computelimit/arm-computelimit/metadata.json | Updates emitter version and apiVersions metadata for 2026-03-20. |
| sdk/computelimit/arm-computelimit/CHANGELOG.md | Updates changelog for stable 1.0.0 release. |
| pnpm-lock.yaml | Adds workspace links for new @azure/core-lro and @azure/abort-controller deps. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
sdk/computelimit/arm-computelimit/samples/v1/typescript/README.md:83
- The samples are now positioned as stable (v1) and the package README links to the API reference without the
?view=azure-node-previewquery. This samples README still points to the preview view; consider updating the[apiref]link to the stable docs URL to avoid sending users to preview documentation.
sdk/computelimit/arm-computelimit/samples/v1/javascript/README.md:71 - The samples are now positioned as stable (v1) and the package README links to the API reference without the
?view=azure-node-previewquery. This samples README still points to the preview view; consider updating the[apiref]link to the stable docs URL to avoid sending users to preview documentation.
Next Steps to MergeOnly failed checks and required actions are listed below.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 tool issue found for @azure/arm-computelimit (new package, first release):
- Package version:
1.0.0is being used for the first release, but Azure SDK guidelines require the first package version to always be a preview (e.g.,1.0.0-beta.1), regardless of API version stability. This is a generation tool issue.
No other public API design concerns found.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":37913,"summary":"issues_found","findings":[{"file":"sdk/computelimit/arm-computelimit/CHANGELOG.md","line":3,"issueType":"tool","category":"package-version","description":"First package release uses stable version 1.0.0; should be 1.0.0-beta.1 per Azure SDK guidelines requiring first release to be preview"}]}⚡ Benchmarked by Management Release Assistant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/computelimit/resource-manager/Microsoft.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'a83147fe12aece4ded0bd96be212e5242e087cb9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087534 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=016d5f6a-0327-f111-8341-000d3a5c46b0 Submitted by: ajbhal@microsoft.com
Release Plan Details
Spec pull request: Microsoft.ComputeLimit: Add new Api for QuotaService feature management azure-rest-api-specs#41661
Spec API version: 03/20/2026