[AutoPR @azure-arm-managednetworkfabric]-generated-from-SDK Generation - JS-6094751#37930
Open
[AutoPR @azure-arm-managednetworkfabric]-generated-from-SDK Generation - JS-6094751#37930
Conversation
…ric.ResourceManager.Management/tspconfig.yaml', API Version: 2024-06-15-preview, SDK Release Type: beta, and CommitSHA: '1a3542f46375ced453982cf69f035d9a9a3924d5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6094751 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
kazrael2119
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng and
qiaozha
as code owners
kazrael2119
added
Self-Service Release
Contributor
There was a problem hiding this comment.
Pull request overview
Updates @azure/arm-managednetworkfabric generated content for the 2024-06-15-preview spec (beta release), primarily refreshing samples and adding/refreshing generated review + tooling artifacts.
Changes:
- Replaced/updated many
samples-dev/*.tsto match the 2024-06-15-preview API surface (including new operations and non-LRO variants). - Removed a large set of legacy
samples/v1/javascript/*.jssamples and simplifiedsample.env. - Added API Extractor review report files and introduced a package-scoped ESLint flat config.
Reviewed changes
Copilot reviewed 295 out of 1095 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/networkDeviceSkusGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/neighborGroupsListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/neighborGroupsListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/neighborGroupsGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/neighborGroupsDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsValidateConfigurationSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsUpdateAdministrativeStateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l3IsolationDomainsCommitConfigurationSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsValidateConfigurationSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsUpdateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsUpdateAdministrativeStateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/l2IsolationDomainsCommitConfigurationSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipPrefixesListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipPrefixesListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipPrefixesGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipPrefixesDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipExtendedCommunitiesListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipExtendedCommunitiesListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipExtendedCommunitiesGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipExtendedCommunitiesDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipCommunitiesListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipCommunitiesListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipCommunitiesGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/ipCommunitiesDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewaysUpdateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewaysListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewaysListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewaysGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewaysDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesUpdateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internetGatewayRulesCreateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internalNetworksListByL3IsolationDomainSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internalNetworksGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/internalNetworksDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/externalNetworksListByL3IsolationDomainSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/externalNetworksGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/externalNetworksDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsValidateConfigurationSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsUpdateAdministrativeStateSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsResyncSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsListBySubscriptionSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsListByResourceGroupSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsGetSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples/v1/javascript/accessControlListsDeleteSample.js | Removed legacy JavaScript sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesValidateConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call shape |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/routePoliciesCommitConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/operationsListSample.ts | Updated dev sample naming + 2024-06-15-preview reference |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkToNetworkInterconnectsUpdateBfdAdministrativeStateSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapsResyncSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapsListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapsGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapsDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesValidateConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesResyncSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkTapRulesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkRacksListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkRacksListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkRacksGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkRacksDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkPacketBrokersListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkPacketBrokersGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkPacketBrokersDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkMonitorsUpdateAdministrativeStateSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkMonitorsListBySubscriptionSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkMonitorsListByResourceGroupSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkMonitorsGetSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkMonitorsDeleteSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkInterfacesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkInterfacesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsViewDeviceConfigurationSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsRefreshConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsProvisionSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsLockFabricSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsGetTopologySample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsDiscardCommitBatchSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsDeprovisionSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsCommitBatchStatusSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricsArmConfigurationDiffSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricSkusListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricSkusGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricControllersListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricControllersListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricControllersGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkFabricControllersDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesRunRwCommandSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesRunRoCommandSample.ts | Added new 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesRefreshConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDevicesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDeviceSkusListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/networkDeviceSkusGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/neighborGroupsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/neighborGroupsListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/neighborGroupsGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/neighborGroupsDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l3IsolationDomainsValidateConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l3IsolationDomainsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l3IsolationDomainsListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l3IsolationDomainsGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l3IsolationDomainsCommitConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l2IsolationDomainsValidateConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l2IsolationDomainsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l2IsolationDomainsListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l2IsolationDomainsGetSample.ts | Updated dev sample to 2024-06-15-preview (note: name casing changed) |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/l2IsolationDomainsCommitConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipPrefixesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipPrefixesListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipPrefixesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipPrefixesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipExtendedCommunitiesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipExtendedCommunitiesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipExtendedCommunitiesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipCommunitiesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipCommunitiesListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipCommunitiesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/ipCommunitiesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewaysListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewaysListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewaysGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewaysDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewayRulesListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewayRulesGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internetGatewayRulesDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internalNetworksUpdateStaticRouteBfdAdministrativeStateSample.ts | Removed older dev sample (static-route specific) |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internalNetworksUpdateBfdAdministrativeStateSample.ts | Added new consolidated 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internalNetworksGetSample.ts | Updated dev sample to 2024-06-15-preview (note: argument values changed) |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/internalNetworksDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/externalNetworksUpdateStaticRouteBfdAdministrativeStateSample.ts | Removed older dev sample (static-route specific) |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/externalNetworksUpdateBfdAdministrativeStateSample.ts | Added new consolidated 2024-06-15-preview dev sample |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/externalNetworksGetSample.ts | Updated dev sample to 2024-06-15-preview (note: argument values changed) |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/externalNetworksDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsValidateConfigurationSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsResyncSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO call |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsListBySubscriptionSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsListByResourceGroupSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsGetSample.ts | Updated dev sample to 2024-06-15-preview |
| sdk/managednetworkfabric/arm-managednetworkfabric/samples-dev/accessControlListsDeleteSample.ts | Updated dev sample to 2024-06-15-preview + non-LRO delete |
| sdk/managednetworkfabric/arm-managednetworkfabric/sample.env | Simplified sample env template (removed credential variable placeholders) |
| sdk/managednetworkfabric/arm-managednetworkfabric/review/arm-managednetworkfabric-api-operations-node.api.md | Added API Extractor review output |
| sdk/managednetworkfabric/arm-managednetworkfabric/review/arm-managednetworkfabric-api-node.api.md | Added API Extractor review output |
| sdk/managednetworkfabric/arm-managednetworkfabric/review/arm-managednetworkfabric-api-networkFabricSkus-node.api.md | Added API Extractor review output |
| sdk/managednetworkfabric/arm-managednetworkfabric/review/arm-managednetworkfabric-api-networkDeviceSkus-node.api.md | Added API Extractor review output |
| sdk/managednetworkfabric/arm-managednetworkfabric/eslint.config.mjs | Added package-scoped ESLint flat config |
| sdk/managednetworkfabric/arm-managednetworkfabric/api-extractor.json | Reformatted json (single-line) |
| sdk/managednetworkfabric/arm-managednetworkfabric/_meta.json | Removed autorest metadata file |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
+9
to
+10
| "@azure/azure-sdk/ts-package-json-files-required": "off", | ||
| "@azure/azure-sdk/ts-package-json-main-is-cjs": "off", |
There was a problem hiding this comment.
The ESLint config turns off rules from eslint-plugin-azure-sdk. Per repo guidelines, avoid disabling @azure/azure-sdk/* rules; prefer fixing the underlying issues or scoping the config to only the intended file patterns so these rules can remain enabled.
| const subscriptionId = "0000ABCD-0A0B-0000-0000-000000ABCDEF"; | ||
| const client = new AzureNetworkFabricManagementServiceAPI(credential, subscriptionId); | ||
| const result = await client.networkFabricSkus.get(networkFabricSkuName); | ||
| const result = await client.networkFabricSkus.get("wxample-fabricsku"); |
There was a problem hiding this comment.
The example SKU name has a typo; this makes the sample look incorrect and inconsistent with other samples using example-* placeholders.
Suggested change
| const result = await client.networkFabricSkus.get("wxample-fabricsku"); | |
| const result = await client.networkFabricSkus.get("example-fabricsku"); |
Comment on lines
+19
to
+20
| "example-externalnetwork", | ||
| "example-ext", |
There was a problem hiding this comment.
The externalNetworks.get sample passes placeholder values that appear swapped/misleading: the second argument should be the L3 isolation domain name, but the placeholder uses example-externalnetwork. This is likely to mislead users and fail against real resources. Use placeholders that match the parameter meaning (e.g., example-l3domain for the L3 isolation domain and example-externalNetwork for the external network name).
Suggested change
| "example-externalnetwork", | |
| "example-ext", | |
| "example-l3domain", | |
| "example-externalNetwork", |
Comment on lines
+19
to
+20
| "example-externalnetwork", | ||
| "example-ext", |
There was a problem hiding this comment.
The argument placeholders here are inconsistent with the operation's parameter semantics (resource group / L3 isolation domain / external network). This makes the sample actively confusing and likely incorrect when copied. Align the placeholder values and naming to the expected parameter meanings (e.g., example-l3domain as the L3 isolation domain).
Suggested change
| "example-externalnetwork", | |
| "example-ext", | |
| "example-l3domain", | |
| "example-externalnetwork", |
| AZURE_CLIENT_SECRET= | ||
| AZURE_CLIENT_ID= | ||
| AZURE_TENANT_ID= No newline at end of file | ||
| # Feel free to add your own environment variables. No newline at end of file |
There was a problem hiding this comment.
This removes the previously documented AZURE_CLIENT_ID, AZURE_TENANT_ID, and AZURE_CLIENT_SECRET placeholders that help users run samples with DefaultAzureCredential. Consider re-adding the standard credential environment variable placeholders (even if left blank) to keep the sample setup guidance actionable.
Suggested change
| # Feel free to add your own environment variables. | |
| # Feel free to add your own environment variables. | |
| AZURE_CLIENT_ID= | |
| AZURE_TENANT_ID= | |
| AZURE_CLIENT_SECRET= |
| const resourceGroupName = process.env["MANAGEDNETWORKFABRIC_RESOURCE_GROUP"] || "example-rg"; | ||
| const routePolicyName = "example-routePolicy"; | ||
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "0000ABCD-0A0B-0000-0000-000000ABCDEF"; |
There was a problem hiding this comment.
Hardcoding subscriptionId in samples makes them less copy/paste runnable and inconsistent with typical Azure SDK samples that read from environment variables (often with a fallback placeholder). Consider restoring process.env[\"MANAGEDNETWORKFABRIC_SUBSCRIPTION_ID\"] || \"...\" and the dotenv/config import pattern (or otherwise documenting how users should provide credentials/subscription id).
Comment on lines
+8
to
+10
| * This sample demonstrates how to bFD administrative state for either static or bgp for internalNetwork. | ||
| * | ||
| * @summary bFD administrative state for either static or bgp for internalNetwork. |
There was a problem hiding this comment.
In the sample description, bFD should be capitalized as BFD.
Suggested change
| * This sample demonstrates how to bFD administrative state for either static or bgp for internalNetwork. | |
| * | |
| * @summary bFD administrative state for either static or bgp for internalNetwork. | |
| * This sample demonstrates how to BFD administrative state for either static or bgp for internalNetwork. | |
| * | |
| * @summary BFD administrative state for either static or bgp for internalNetwork. |
Next Steps to MergeOnly failed checks and required actions are listed below.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
No API design or tooling issues found for this TypeSpec migration of @azure/arm-managednetworkfabric (2.0.0-beta.1).
Checked:
- ✅ Version alignment:
package.json,src/api/azureNetworkFabricManagementServiceAPIContext.ts, andCHANGELOG.mdall consistently use2.0.0-beta.1 - ✅ No alpha versions present
- ✅ Client name unchanged (
AzureNetworkFabricManagementServiceAPI) - ✅ Constructor parameters unchanged (
credential,subscriptionId,options?) - ✅
KnownVersionsincludes bothV20240215PreviewandV20240615Preview - ✅ No
_Nsuffixes,AutoGeneratedsuffixes, or_prefix naming issues - ✅ No
unknowntypes in public models - ✅ No
voidon create/update/get/list operations - ✅ No
ae-forgotten-exportwarnings - ✅ No DOM name clashes (
Request,Response,Event)
📊 Structured Report
{"agent":"mgmt-reviewer","pr":37930,"summary":"clean","findings":[]}⚡ Benchmarked by Management Release Assistant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/managednetworkfabric/ManagedNetworkFabric.ResourceManager.Management/tspconfig.yaml', API Version: 2024-06-15-preview, SDK Release Type: beta, and CommitSHA: '1a3542f46375ced453982cf69f035d9a9a3924d5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6094751 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=5f27c1fe-fe2d-f111-88b4-000d3a59735f Submitted by: nafizhaider@microsoft.com
Release Plan Details
Spec pull request: Managednetworkfabric 202-07-15 API azure-rest-api-specs#41138
Spec API version: 2024-06-15-preview