[AutoPR @azure-arm-servicefabric]-generated-from-SDK Generation - JS-6101245#37944
Open
[AutoPR @azure-arm-servicefabric]-generated-from-SDK Generation - JS-6101245#37944
Conversation
…ft.ServiceFabric/ServiceFabric/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'a3fd1efe038ca9c4a0042c3ee3afe6b279079ff6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6101245 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
kazrael2119
added
Self-Service Release
kazrael2119
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng and
qiaozha
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be an AutoRest/TypeSpec regeneration for @azure/arm-servicefabric targeting API version 2026-03-01-preview (beta), including new generated REST “api” surface, “classic” convenience layer, updated samples, and API Extractor reports.
Changes:
- Added new generated client context + helpers (cloud environment selection, logger) and new operation groups (e.g.,
unsupportedVmSizes). - Replaced legacy generated artifacts (paging / lro impl and
operationsInterfaces/*) with the new generation structure (src/api/*,src/classic/*,review/*.api.md). - Refreshed samples (added
v4-beta, removed olderv3samples) and introduced package-level ESLint flat config.
Reviewed changes
Copilot reviewed 242 out of 258 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicefabric/arm-servicefabric/src/static-helpers/cloudSettingHelpers.ts | Adds cloud-to-ARM endpoint mapping helper and cloud enum/type. |
| sdk/servicefabric/arm-servicefabric/src/pagingHelper.ts | Removes legacy continuation token paging helper. |
| sdk/servicefabric/arm-servicefabric/src/operationsInterfaces/operations.ts | Removes legacy Operations interface definition. |
| sdk/servicefabric/arm-servicefabric/src/operationsInterfaces/index.ts | Removes legacy operationsInterfaces barrel export. |
| sdk/servicefabric/arm-servicefabric/src/operationsInterfaces/clusterVersions.ts | Removes legacy ClusterVersions interface definition. |
| sdk/servicefabric/arm-servicefabric/src/operationsInterfaces/applicationTypes.ts | Removes legacy ApplicationTypes interface definition. |
| sdk/servicefabric/arm-servicefabric/src/operations/index.ts | Removes legacy operations/* barrel export. |
| sdk/servicefabric/arm-servicefabric/src/lroImpl.ts | Removes legacy LRO spec helper implementation. |
| sdk/servicefabric/arm-servicefabric/src/logger.ts | Adds package logger via @azure/logger. |
| sdk/servicefabric/arm-servicefabric/src/classic/unsupportedVmSizes/index.ts | Adds classic wrapper for unsupportedVmSizes operations. |
| sdk/servicefabric/arm-servicefabric/src/classic/operations/index.ts | Adds classic wrapper for provider operations.list. |
| sdk/servicefabric/arm-servicefabric/src/classic/index.ts | Exposes classic operation-group operation types. |
| sdk/servicefabric/arm-servicefabric/src/classic/clusterVersions/index.ts | Adds classic wrapper for clusterVersions operations. |
| sdk/servicefabric/arm-servicefabric/src/api/unsupportedVmSizes/options.ts | Adds REST options types for unsupportedVmSizes. |
| sdk/servicefabric/arm-servicefabric/src/api/unsupportedVmSizes/index.ts | Adds REST export surface for unsupportedVmSizes. |
| sdk/servicefabric/arm-servicefabric/src/api/services/options.ts | Adds REST options types for services operations (incl. polling interval). |
| sdk/servicefabric/arm-servicefabric/src/api/services/index.ts | Adds REST export surface for services. |
| sdk/servicefabric/arm-servicefabric/src/api/serviceFabricManagementContext.ts | Adds generated REST client context factory and client options, incl. cloud selection and logging. |
| sdk/servicefabric/arm-servicefabric/src/api/operations/options.ts | Adds REST options type for operations.list. |
| sdk/servicefabric/arm-servicefabric/src/api/operations/operations.ts | Adds generated REST implementation for operations.list with paging and deserialization. |
| sdk/servicefabric/arm-servicefabric/src/api/operations/index.ts | Adds REST export surface for operations. |
| sdk/servicefabric/arm-servicefabric/src/api/index.ts | Adds REST context exports + factory export. |
| sdk/servicefabric/arm-servicefabric/src/api/clusters/options.ts | Adds REST options types for clusters operations (incl. polling interval). |
| sdk/servicefabric/arm-servicefabric/src/api/clusters/index.ts | Adds REST export surface for clusters. |
| sdk/servicefabric/arm-servicefabric/src/api/clusterVersions/options.ts | Adds REST options types for clusterVersions operations. |
| sdk/servicefabric/arm-servicefabric/src/api/clusterVersions/index.ts | Adds REST export surface for clusterVersions. |
| sdk/servicefabric/arm-servicefabric/src/api/applications/options.ts | Adds REST options types for applications operations (incl. polling interval). |
| sdk/servicefabric/arm-servicefabric/src/api/applications/index.ts | Adds REST export surface for applications. |
| sdk/servicefabric/arm-servicefabric/src/api/applicationTypes/options.ts | Adds REST options types for applicationTypes operations. |
| sdk/servicefabric/arm-servicefabric/src/api/applicationTypes/index.ts | Adds REST export surface for applicationTypes. |
| sdk/servicefabric/arm-servicefabric/src/api/applicationTypeVersions/options.ts | Adds REST options types for applicationTypeVersions operations (incl. polling interval). |
| sdk/servicefabric/arm-servicefabric/src/api/applicationTypeVersions/index.ts | Adds REST export surface for applicationTypeVersions. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/tsconfig.json | Adds TypeScript sample build config for v4-beta. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/unsupportedVmSizesListSample.ts | Adds TS v4-beta sample for listing unsupported VM sizes. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/unsupportedVmSizesGetSample.ts | Adds TS v4-beta sample for getting one unsupported VM size. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/servicesUpdateSample.ts | Adds TS v4-beta sample for updating a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/servicesListSample.ts | Adds TS v4-beta sample for listing services. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/servicesGetSample.ts | Adds TS v4-beta sample for getting a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/servicesDeleteSample.ts | Adds TS v4-beta sample for deleting a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/servicesCreateOrUpdateSample.ts | Adds TS v4-beta sample for creating/updating a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/operationsListSample.ts | Adds TS v4-beta sample for listing provider operations. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clustersListUpgradableVersionsSample.ts | Adds TS v4-beta sample for cluster upgrade path listing. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clustersListSample.ts | Adds TS v4-beta sample for listing clusters. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clustersListByResourceGroupSample.ts | Adds TS v4-beta sample for listing clusters by RG. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clustersGetSample.ts | Adds TS v4-beta sample for getting a cluster. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clustersDeleteSample.ts | Adds TS v4-beta sample for deleting a cluster. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clusterVersionsListSample.ts | Adds TS v4-beta sample for listing cluster versions. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clusterVersionsListByEnvironmentSample.ts | Adds TS v4-beta sample for listing cluster versions by environment. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clusterVersionsGetSample.ts | Adds TS v4-beta sample for getting a cluster version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/clusterVersionsGetByEnvironmentSample.ts | Adds TS v4-beta sample for getting a cluster version by environment. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationsUpdateSample.ts | Adds TS v4-beta sample for updating an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationsListSample.ts | Adds TS v4-beta sample for listing applications. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationsGetSample.ts | Adds TS v4-beta sample for getting an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationsDeleteSample.ts | Adds TS v4-beta sample for deleting an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypesListSample.ts | Adds TS v4-beta sample for listing application types. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypesGetSample.ts | Adds TS v4-beta sample for getting an application type. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypesDeleteSample.ts | Adds TS v4-beta sample for deleting an application type. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypesCreateOrUpdateSample.ts | Adds TS v4-beta sample for creating/updating application types. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypeVersionsListSample.ts | Adds TS v4-beta sample for listing application type versions. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypeVersionsGetSample.ts | Adds TS v4-beta sample for getting an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypeVersionsDeleteSample.ts | Adds TS v4-beta sample for deleting an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/src/applicationTypeVersionsCreateOrUpdateSample.ts | Adds TS v4-beta sample for creating/updating an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/sample.env | Adds placeholder env file for TS samples. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/typescript/package.json | Updates TS samples package metadata for beta and uses next package dependency. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/unsupportedVmSizesListSample.js | Adds JS v4-beta sample for listing unsupported VM sizes. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/unsupportedVmSizesGetSample.js | Adds JS v4-beta sample for getting one unsupported VM size. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/servicesUpdateSample.js | Adds JS v4-beta sample for updating a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/servicesListSample.js | Adds JS v4-beta sample for listing services. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/servicesGetSample.js | Adds JS v4-beta sample for getting a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/servicesDeleteSample.js | Adds JS v4-beta sample for deleting a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/servicesCreateOrUpdateSample.js | Adds JS v4-beta sample for creating/updating a service. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/sample.env | Adds placeholder env file for JS samples. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/package.json | Updates JS samples package metadata for beta and uses next package dependency. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/operationsListSample.js | Adds JS v4-beta sample for listing provider operations. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clustersListUpgradableVersionsSample.js | Adds JS v4-beta sample for cluster upgrade path listing. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clustersListSample.js | Adds JS v4-beta sample for listing clusters. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clustersListByResourceGroupSample.js | Adds JS v4-beta sample for listing clusters by RG. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clustersGetSample.js | Adds JS v4-beta sample for getting a cluster. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clustersDeleteSample.js | Adds JS v4-beta sample for deleting a cluster. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clusterVersionsListSample.js | Adds JS v4-beta sample for listing cluster versions. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clusterVersionsListByEnvironmentSample.js | Adds JS v4-beta sample for listing cluster versions by environment. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clusterVersionsGetSample.js | Adds JS v4-beta sample for getting a cluster version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/clusterVersionsGetByEnvironmentSample.js | Adds JS v4-beta sample for getting a cluster version by environment. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationsUpdateSample.js | Adds JS v4-beta sample for updating an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationsListSample.js | Adds JS v4-beta sample for listing applications. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationsGetSample.js | Adds JS v4-beta sample for getting an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationsDeleteSample.js | Adds JS v4-beta sample for deleting an application. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypesListSample.js | Adds JS v4-beta sample for listing application types. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypesGetSample.js | Adds JS v4-beta sample for getting an application type. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypesDeleteSample.js | Adds JS v4-beta sample for deleting an application type. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypesCreateOrUpdateSample.js | Adds JS v4-beta sample for creating/updating an application type. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypeVersionsListSample.js | Adds JS v4-beta sample for listing application type versions. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypeVersionsGetSample.js | Adds JS v4-beta sample for getting an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypeVersionsDeleteSample.js | Adds JS v4-beta sample for deleting an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v4-beta/javascript/applicationTypeVersionsCreateOrUpdateSample.js | Adds JS v4-beta sample for creating/updating an application type version. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/tsconfig.json | Removes legacy v3 TS sample tsconfig. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/servicesUpdateSample.ts | Removes legacy v3 TS service update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/servicesListSample.ts | Removes legacy v3 TS service list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/servicesGetSample.ts | Removes legacy v3 TS service get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/servicesDeleteSample.ts | Removes legacy v3 TS service delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/operationsListSample.ts | Removes legacy v3 TS operations list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clustersListUpgradableVersionsSample.ts | Removes legacy v3 TS cluster upgradable versions sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clustersListSample.ts | Removes legacy v3 TS clusters list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clustersListByResourceGroupSample.ts | Removes legacy v3 TS clusters list-by-RG sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clustersGetSample.ts | Removes legacy v3 TS cluster get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clustersDeleteSample.ts | Removes legacy v3 TS cluster delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clusterVersionsListSample.ts | Removes legacy v3 TS cluster versions list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clusterVersionsListByEnvironmentSample.ts | Removes legacy v3 TS cluster versions list-by-env sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clusterVersionsGetSample.ts | Removes legacy v3 TS cluster versions get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/clusterVersionsGetByEnvironmentSample.ts | Removes legacy v3 TS cluster versions get-by-env sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationsUpdateSample.ts | Removes legacy v3 TS applications update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationsListSample.ts | Removes legacy v3 TS applications list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationsGetSample.ts | Removes legacy v3 TS applications get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationsDeleteSample.ts | Removes legacy v3 TS applications delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypesListSample.ts | Removes legacy v3 TS application types list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypesGetSample.ts | Removes legacy v3 TS application types get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypesDeleteSample.ts | Removes legacy v3 TS application types delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypesCreateOrUpdateSample.ts | Removes legacy v3 TS application types create/update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypeVersionsListSample.ts | Removes legacy v3 TS app type versions list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypeVersionsGetSample.ts | Removes legacy v3 TS app type versions get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypeVersionsDeleteSample.ts | Removes legacy v3 TS app type versions delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/src/applicationTypeVersionsCreateOrUpdateSample.ts | Removes legacy v3 TS app type versions create/update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/typescript/sample.env | Removes legacy v3 TS sample env template. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/servicesUpdateSample.js | Removes legacy v3 JS service update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/servicesListSample.js | Removes legacy v3 JS service list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/servicesGetSample.js | Removes legacy v3 JS service get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/servicesDeleteSample.js | Removes legacy v3 JS service delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/sample.env | Removes legacy v3 JS sample env template. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/operationsListSample.js | Removes legacy v3 JS operations list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clustersListUpgradableVersionsSample.js | Removes legacy v3 JS clusters upgradable versions sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clustersListSample.js | Removes legacy v3 JS clusters list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clustersListByResourceGroupSample.js | Removes legacy v3 JS clusters list-by-RG sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clustersGetSample.js | Removes legacy v3 JS clusters get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clustersDeleteSample.js | Removes legacy v3 JS clusters delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clusterVersionsListSample.js | Removes legacy v3 JS cluster versions list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clusterVersionsListByEnvironmentSample.js | Removes legacy v3 JS cluster versions list-by-env sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clusterVersionsGetSample.js | Removes legacy v3 JS cluster versions get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/clusterVersionsGetByEnvironmentSample.js | Removes legacy v3 JS cluster versions get-by-env sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationsUpdateSample.js | Removes legacy v3 JS applications update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationsListSample.js | Removes legacy v3 JS applications list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationsGetSample.js | Removes legacy v3 JS applications get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationsDeleteSample.js | Removes legacy v3 JS applications delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypesListSample.js | Removes legacy v3 JS application types list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypesGetSample.js | Removes legacy v3 JS application types get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypesDeleteSample.js | Removes legacy v3 JS application types delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypesCreateOrUpdateSample.js | Removes legacy v3 JS application types create/update sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypeVersionsListSample.js | Removes legacy v3 JS app type versions list sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypeVersionsGetSample.js | Removes legacy v3 JS app type versions get sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypeVersionsDeleteSample.js | Removes legacy v3 JS app type versions delete sample. |
| sdk/servicefabric/arm-servicefabric/samples/v3/javascript/applicationTypeVersionsCreateOrUpdateSample.js | Removes legacy v3 JS app type versions create/update sample. |
| sdk/servicefabric/arm-servicefabric/samples-dev/unsupportedVmSizesListSample.ts | Adds/updates dev sample for listing unsupported VM sizes for new API version. |
| sdk/servicefabric/arm-servicefabric/samples-dev/unsupportedVmSizesGetSample.ts | Adds/updates dev sample for getting one unsupported VM size for new API version. |
| sdk/servicefabric/arm-servicefabric/samples-dev/servicesUpdateSample.ts | Updates dev sample to new services.update shape and new API version. |
| sdk/servicefabric/arm-servicefabric/samples-dev/servicesListSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/servicesGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/servicesDeleteSample.ts | Updates dev sample to new API version and new delete method. |
| sdk/servicefabric/arm-servicefabric/samples-dev/operationsListSample.ts | Updates dev sample to new API version and revised client construction. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clustersUpdateSample.ts | Updates dev sample to new clusters.update call pattern and API version. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clustersListSample.ts | Updates dev sample to new API version and hardcoded subscriptionId. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clustersListByResourceGroupSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clustersGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clustersDeleteSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clusterVersionsListSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clusterVersionsListByEnvironmentSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clusterVersionsGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/clusterVersionsGetByEnvironmentSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationsUpdateSample.ts | Updates dev sample to new applications.update shape and API version. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationsListSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationsGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationsDeleteSample.ts | Updates dev sample to new API version and revised delete method. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypesListSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypesGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypesDeleteSample.ts | Updates dev sample to new API version and revised delete method. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypesCreateOrUpdateSample.ts | Updates dev sample to new API version and revised createOrUpdate call. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypeVersionsListSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypeVersionsGetSample.ts | Updates dev sample to new API version and hardcoded placeholders. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypeVersionsDeleteSample.ts | Updates dev sample to new API version and revised delete method. |
| sdk/servicefabric/arm-servicefabric/samples-dev/applicationTypeVersionsCreateOrUpdateSample.ts | Updates dev sample to new API version and revised createOrUpdate call. |
| sdk/servicefabric/arm-servicefabric/sample.env | Replaces previous env template with generic placeholder text. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-unsupportedVmSizes-node.api.md | Adds API Extractor report for unsupportedVmSizes surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-services-node.api.md | Adds API Extractor report for services surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-operations-node.api.md | Adds API Extractor report for operations surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-node.api.md | Adds top-level API Extractor report for the package. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-clusters-node.api.md | Adds API Extractor report for clusters surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-clusterVersions-node.api.md | Adds API Extractor report for clusterVersions surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-applications-node.api.md | Adds API Extractor report for applications surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-applicationTypes-node.api.md | Adds API Extractor report for applicationTypes surface. |
| sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-api-applicationTypeVersions-node.api.md | Adds API Extractor report for applicationTypeVersions surface. |
| sdk/servicefabric/arm-servicefabric/eslint.config.mjs | Adds package ESLint flat config and rule overrides. |
| sdk/servicefabric/arm-servicefabric/api-extractor.json | Reformats API Extractor config into one line. |
| sdk/servicefabric/arm-servicefabric/_meta.json | Removes legacy autorest metadata file. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
+43
to
+50
| const { apiVersion: _, ...updatedOptions } = { | ||
| ...options, | ||
| userAgentOptions: { userAgentPrefix }, | ||
| loggingOptions: { logger: options.loggingOptions?.logger ?? logger.info }, | ||
| credentials: { scopes: options.credentials?.scopes ?? [`${endpointUrl}/.default`] }, | ||
| }; | ||
| const clientContext = getClient(endpointUrl, credential, updatedOptions); | ||
| const apiVersion = options.apiVersion; |
There was a problem hiding this comment.
const { apiVersion: _, ...updatedOptions } = ... introduces a local _ binding that is never used, which will fail builds when noUnusedLocals is enabled (common in this repo). Prefer destructuring into a used variable (e.g., apiVersion) or avoid creating a binding at all while omitting the property (e.g., pick apiVersion into a variable that you actually return/use, and spread the rest into updatedOptions).
Suggested change
| const { apiVersion: _, ...updatedOptions } = { | |
| ...options, | |
| userAgentOptions: { userAgentPrefix }, | |
| loggingOptions: { logger: options.loggingOptions?.logger ?? logger.info }, | |
| credentials: { scopes: options.credentials?.scopes ?? [`${endpointUrl}/.default`] }, | |
| }; | |
| const clientContext = getClient(endpointUrl, credential, updatedOptions); | |
| const apiVersion = options.apiVersion; | |
| const { apiVersion, ...updatedOptions } = { | |
| ...options, | |
| userAgentOptions: { userAgentPrefix }, | |
| loggingOptions: { logger: options.loggingOptions?.logger ?? logger.info }, | |
| credentials: { scopes: options.credentials?.scopes ?? [`${endpointUrl}/.default`] }, | |
| }; | |
| const clientContext = getClient(endpointUrl, credential, updatedOptions); |
Comment on lines
+30
to
+37
| /** Azure Service Fabric Resource Provider API Client */ | ||
| export function createServiceFabricManagement( | ||
| credential: TokenCredential, | ||
| subscriptionId: string, | ||
| options: ServiceFabricManagementClientOptionalParams = {}, | ||
| ): ServiceFabricManagementContext { | ||
| const endpointUrl = | ||
| options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com"; |
There was a problem hiding this comment.
endpointUrl can include a trailing / (e.g., from getArmEndpoint), which produces a double slash in the default scope (https://...//.default). This can break AAD scope matching. Normalize endpointUrl (trim trailing slashes) before using it both for getClient(...) and when building the default scopes.
Suggested change
| /** Azure Service Fabric Resource Provider API Client */ | |
| export function createServiceFabricManagement( | |
| credential: TokenCredential, | |
| subscriptionId: string, | |
| options: ServiceFabricManagementClientOptionalParams = {}, | |
| ): ServiceFabricManagementContext { | |
| const endpointUrl = | |
| options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com"; | |
| /** | |
| * Normalizes a service endpoint URL by removing trailing slashes. | |
| * | |
| * @internal | |
| */ | |
| function normalizeEndpointUrl(endpointUrl: string): string { | |
| return endpointUrl.replace(/\/+$/, ""); | |
| } | |
| /** Azure Service Fabric Resource Provider API Client */ | |
| export function createServiceFabricManagement( | |
| credential: TokenCredential, | |
| subscriptionId: string, | |
| options: ServiceFabricManagementClientOptionalParams = {}, | |
| ): ServiceFabricManagementContext { | |
| const endpointUrl = normalizeEndpointUrl( | |
| options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com", | |
| ); |
Comment on lines
+46
to
+47
| loggingOptions: { logger: options.loggingOptions?.logger ?? logger.info }, | ||
| credentials: { scopes: options.credentials?.scopes ?? [`${endpointUrl}/.default`] }, |
There was a problem hiding this comment.
endpointUrl can include a trailing / (e.g., from getArmEndpoint), which produces a double slash in the default scope (https://...//.default). This can break AAD scope matching. Normalize endpointUrl (trim trailing slashes) before using it both for getClient(...) and when building the default scopes.
| */ | ||
| async function listAvailableOperations(): Promise<void> { | ||
| const credential = new DefaultAzureCredential(); | ||
| const client = new ServiceFabricManagementClient(credential); |
There was a problem hiding this comment.
The sample constructs ServiceFabricManagementClient without a subscriptionId, while other samples in the same folder pass a subscriptionId and the generated REST context factory requires it. This is likely to be a compile/runtime error. Update the sample to pass a subscriptionId (even if the specific operation is subscription-less) consistent with the client constructor signature used elsewhere in this PR.
Suggested change
| const client = new ServiceFabricManagementClient(credential); | |
| const subscriptionId = | |
| process.env["AZURE_SUBSCRIPTION_ID"] || "<subscriptionId>"; | |
| const client = new ServiceFabricManagementClient(credential, subscriptionId); |
| "compilerOptions": { | ||
| "target": "ES2023", | ||
| "module": "commonjs", | ||
| "lib": [], |
There was a problem hiding this comment.
Setting "lib": [] removes all built-in library type definitions (including Promise, AsyncIterable, etc.), which will break TypeScript compilation for these samples. Use an appropriate lib list (e.g., include ES2023, and DOM only if needed) or remove the lib override entirely to allow TypeScript defaults based on target.
Suggested change
| "lib": [], |
Comment on lines
+9
to
+10
| "@azure/azure-sdk/ts-package-json-files-required": "off", | ||
| "@azure/azure-sdk/ts-package-json-main-is-cjs": "off", |
There was a problem hiding this comment.
The config disables @azure/eslint-plugin-azure-sdk rules. In this repo we should avoid turning off Azure SDK lint rules; instead prefer fixing package.json (or adjusting generation) to satisfy them, or (at most) downgrade to "warn" if there’s a documented repo-wide exception. Please re-enable these rules and address the underlying violations.
Suggested change
| "@azure/azure-sdk/ts-package-json-files-required": "off", | |
| "@azure/azure-sdk/ts-package-json-main-is-cjs": "off", | |
| "@azure/azure-sdk/ts-package-json-files-required": "warn", | |
| "@azure/azure-sdk/ts-package-json-main-is-cjs": "warn", |
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { createClientLogger } from "@azure/logger"; |
There was a problem hiding this comment.
logger is exported but lacks a TSDoc comment. Please add a brief TSDoc describing what the logger is for and its expected usage (e.g., intended subsystem name and that it integrates with @azure/logger).
Suggested change
| import { createClientLogger } from "@azure/logger"; | |
| import { createClientLogger } from "@azure/logger"; | |
| /** | |
| * The default logger for the `arm-servicefabric` client library. | |
| * | |
| * Use this logger for diagnostic output from this package. It integrates with | |
| * `@azure/logger` and uses the `arm-servicefabric` namespace for log filtering | |
| * and configuration. | |
| */ |
Next Steps to MergeOnly failed checks and required actions are listed below.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 tool issue found in the public API surface.
StatelessServiceProperties.minInstancePercentage— typed asUint8Arrayinstead ofnumber. A percentage value should be a numeric type; this appears to be a generation tool mapping error.
All other checks passed: version alignment (4.0.0-beta.1 consistent across package.json, context file, and CHANGELOG.md), no alpha versions, first release is correctly a preview (-beta.1), no _N/AutoGenerated suffix naming issues, no unknown type safety issues, and no forgotten export warnings.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":37944,"summary":"issues_found","findings":[{"file":"sdk/servicefabric/arm-servicefabric/review/arm-servicefabric-node.api.md","line":1185,"issueType":"tool","category":"type-safety","description":"minInstancePercentage is typed as Uint8Array instead of number — likely a generation tool type-mapping error"}]}⚡ Benchmarked by Management Release Assistant
| instanceCloseDelayDuration?: string; | ||
| instanceCount?: number; | ||
| minInstanceCount?: number; | ||
| minInstancePercentage?: Uint8Array; |
There was a problem hiding this comment.
🔴 Tool Issue — StatelessServiceProperties.minInstancePercentage
minInstancePercentage?: Uint8Array;minInstancePercentage represents a percentage value (0–100) in the Service Fabric spec, but it is mapped to Uint8Array here. This is a generation tool type-mapping error.
Fix: This should be number (or number | null) rather than Uint8Array. Please report this issue in the generation tool repository and regenerate after the fix is applied. Alternatively, add a @clientType or equivalent override in the TypeSpec client.tsp to force the correct mapped type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/servicefabric/resource-manager/Microsoft.ServiceFabric/ServiceFabric/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'a3fd1efe038ca9c4a0042c3ee3afe6b279079ff6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6101245 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=18134e38-cf2e-f111-88b4-000d3a5a7991 Submitted by: iliu@microsoft.com
Release Plan Details
Spec pull request: Fix Diff in ServiceFabric azure-rest-api-specs#40420
Spec API version: 2026-03-01-preview