[Storage] Regenerate azure_storage_blob against feature branch + set_metadata properly authored#3862
Merged
vincenttran-msft merged 8 commits intoAzure:mainfrom Mar 10, 2026
Conversation
github-actions
bot
added
Event Hubs
Storage
vincenttran-msft
requested review from
LarryOsterman,
RickWinter,
heaths,
j7nw4r and
jalauzon-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Regenerates azure_storage_blob from the referenced azure-rest-api-specs commit and updates conditional request option types to use the strongly-typed Etag, including fixing call sites that set metadata / conditional headers.
Changes:
- Updated the
tsp-location.yamlpinned spec commit forazure_storage_blob. - Converted conditional option fields (e.g.,
if_match,if_none_match) fromOption<String>toOption<Etag>and updated usages/tests accordingly. - Documented the breaking API changes in
sdk/storage/azure_storage_blob/CHANGELOG.md.
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob/tsp-location.yaml | Updates the pinned swagger/spec commit used for generation. |
| sdk/storage/azure_storage_blob/tests/blob_client_options.rs | Adjusts tests to pass Etag directly into conditional options. |
| sdk/storage/azure_storage_blob/src/models/method_options.rs | Changes conditional option field types to Option<Etag>. |
| sdk/storage/azure_storage_blob/src/clients/blob_client.rs | Updates conditional header value to use Etag (*) when overwrite is false. |
| sdk/storage/azure_storage_blob/CHANGELOG.md | Adds breaking-change notes for the Etag-typed conditional fields and other renames. |
| sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/src/checkpoint_store.rs | Updates metadata and upload options to use Etag instead of string conversions. |
jalauzon-msft
approved these changes
Mar 9, 2026
jalauzon-msft
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.tsp:Azure/azure-rest-api-specs#41077