Cosmos: Fix spec inaccuracies in PPAF/PPCB design doc#3918
Draft
Copilot wants to merge 6 commits intorelease/azure_data_cosmos-previewsfrom
Draft
Cosmos: Fix spec inaccuracies in PPAF/PPCB design doc#3918Copilot wants to merge 6 commits intorelease/azure_data_cosmos-previewsfrom
Copilot wants to merge 6 commits intorelease/azure_data_cosmos-previewsfrom
Conversation
- Fix background failback description: clarify it scans PPCB map only, not all failed-over partitions (§9.4 scope limitation) - Fix partition_level_circuit_breaker_enabled description: replace misleading "master switch" with accurate OR-logic explanation - Fix ReadSessionNotAvailable substatus: 1002 not 1022 (1022=LeaseNotFound) - Fix PartitionKeyRange struct: add resource_id field and update equality/ hashing description to include id+resource_id+min_inclusive+max_exclusive - Fix broken link: TRANSPORT_PIPELINE_SPEC.md → correct relative path Co-authored-by: FabianMeiswinkel <19165014+FabianMeiswinkel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add per partition automatic failover and circuit breaker specs
Cosmos: Fix spec inaccuracies in PPAF/PPCB design doc
Mar 11, 2026
Base automatically changed from
users/kundadebdatta/add_ppaf_spec_for_driver
to
release/azure_data_cosmos-previews
March 16, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five correctness discrepancies between the spec and the actual implementation, identified during review.
Fixes
1022→1002in the status-code matrix.1022isLeaseNotFound;1002isReadSessionNotAvailable(aliased asPARTITION_KEY_RANGE_GONEon HTTP 410).partition_level_circuit_breaker_enableddescription: Replaced "master switch" with the actual OR-logic — PPCB is active ifenable_per_partition_failover_behavior || partition_level_circuit_breaker_enabled. Setting the env var tofalseonly disables PPCB when the server flag is alsofalse.PartitionKeyRangeequality/hashing: Updated the struct snippet to includeresource_id: Option<String>and corrected the description — hashing coversid,resource_id,min_inclusive, andmax_exclusive, notidalone. Floating-point throughput fields are excluded becausef64doesn't implementHash.TRANSPORT_PIPELINE_SPEC.md→../azure_data_cosmos_driver/docs/TRANSPORT_PIPELINE_SPEC.md.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.