Draft
Conversation
heaths
approved these changes
Mar 31, 2026
Member
heaths
left a comment
There was a problem hiding this comment.
Yeah, this could work. I was debating on whether we should take an Option<&str> or something instead of reading env vars here, but we read env vars above for Kestrel.
I still wonder if we want to take this, though, instead of figuring out how/why the port is already in use. If we (almost definitely) rightly assume no other agents are running on those machines, when we fail to bind should we actually query and report on what's running off port 5000? This feels more like papering over the problem than trying to understand the root cause and fix it. Then again, maybe it's rare enough it's not worth the investigative effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LarryOsterman here is an example.
@heaths I made a change in
existing()to honor an optional value. That might get me yelled at but we'll see 😆