Show Public/Private badge on My Plan items#13
Merged
Conversation
Attendees can now tell at a glance which items on their plan are official public events vs private custom items, matching what admins see on the Schedule Items index. Uses the existing .item-badge pattern with new public (filled mint) and private (outlined gray) variants.
|
🚅 Deployed to the ruby-embassy-pr-13 environment in ruby-embassy
|
railway-app
Bot
temporarily deployed
to
ruby-embassy / ruby-embassy-pr-13
Resolves conflict in app/views/plan/_plan_item.html.erb: main introduced an embassy-appointment branch that re-indented the standard plan-item render block. Kept main's new structure and reapplied the Public/Private badge inside the non-embassy else branch at the deeper indent level.
railway-app
Bot
temporarily deployed
to
ruby-embassy / ruby-embassy-pr-13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublicorPrivatebadge to each item on the attendee-facing/planpage, driven byschedule_item.is_public?— mirroring what admins see on the Schedule Items index so attendees can tell official events apart from private custom items at a glance..item-badgesystem:.item-badge--public(soft mint filled) and.item-badge--private(gray outlined), placed next to.item-badge--customfor visual consistency.is_publicboolean already backing the admin view. The existingCustombadge stays alongside since it represents a different dimension (who created it vs. who can see it).Test plan
/plan— confirm each item shows aPublicorPrivatebadge alongside the kind badge.Customin addition to the new visibility badge./admin/schedule_items— no change expected.