Hide role-irrelevant Schedule kind filters; show "Lightning Talks"#20
Merged
Hide role-irrelevant Schedule kind filters; show "Lightning Talks"#20
Conversation
Volunteer filter now shows only to Volunteers and Admins. Reception filter is hidden everywhere. Remaining filter buttons are alphabetized by display label, and the `lightning` kind shows as "Lightning Talks" in the filter and the badge on cards. The DB enum and controller filter param remain unchanged.
|
🚅 Deployed to the ruby-embassy-pr-20 environment in ruby-embassy
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lightningrenders as "Lightning Talks" in both the filter button and the badge on event cards.ScheduleHelper(kind_display_label,visible_filter_kinds); the DB enum,by_kindscope, and controller param validation are unchanged so URLs like?kind=lightningstill work.Test plan
/schedule: filter shows All, Activity, Community, Embassy, Lightning Talks, Meal, Talk (no Volunteer, no Reception)/admin/schedule_itemsshows the same filter list and the Kind column shows "Lightning Talks" for Lightning rows/schedule, any Lightning event card's badge reads "Lightning Talks" and brand styling on.item-badge--lightningis preserved/schedule?kind=lightningand only Lightning items appear