plugins types BUGFIX print same IPv6 format as stored#2509
Open
jeremie6wind wants to merge 1 commit intoCESNET:develfrom
Open
plugins types BUGFIX print same IPv6 format as stored#2509jeremie6wind wants to merge 1 commit intoCESNET:develfrom
jeremie6wind wants to merge 1 commit intoCESNET:develfrom
Conversation
The stored IPv6 address is sometimes not the same as the printed one. For instance, if a compressed IPv6 address ::2222:1111 is stored, then a dual stack IPv6 address ::34.34.17.17 will be printed. This is due to the inet_ntop function implementation. The aim of this patch is to store the IPv6 format and print the same format. Store the IPv6 format with the value. Introduce ipv6address_ip2str that converts back the IPv4 part if necessary. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The stored IPv6 address is sometimes not the same as the printed one.
For instance, if a compressed IPv6 address ::2222:1111 is stored, then a dual stack IPv6 address ::34.34.17.17 will be printed. This is due to the inet_ntop function implementation.
The aim of this patch is to store the IPv6 format and print the same format.
Store the IPv6 format with the value.
Introduce ipv6address_ip2str that converts back the IPv4 part if necessary.
Thank you
Best regards
Jeremie