Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205
Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205dillten wants to merge 1 commit intoCoMPaTech:mainfrom
Conversation
|
WalkthroughTwo minimal data entries are added to the codebase: an IEEE 802.11n/NG mode enum value ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@airos/model_map.py`:
- Line 88: The dict in model_map contains a key "NanoStation loco M900 " with a
trailing space which causes mismatches in get_sku_by_devmodel and leaks from
get_devmodel_by_sku; remove the stray trailing space from the key so it becomes
"NanoStation loco M900" to restore exact-match O(1) lookups and prevent the
SKU->devmodel getter from returning a padded string, ensuring other sibling keys
(e.g., "NanoStation loco M5") remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1ad0f13c-f4ff-49c2-a6f0-25c14cb94c3a
📒 Files selected for processing (2)
airos/data.pyairos/model_map.py



Adds M900 legacy model to the models list.
Summary by CodeRabbit