Skip to content

Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205

Open
dillten wants to merge 1 commit intoCoMPaTech:mainfrom
dillten:feature-add-legacy-M900-station
Open

Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205
dillten wants to merge 1 commit intoCoMPaTech:mainfrom
dillten:feature-add-legacy-M900-station

Conversation

@dillten
Copy link
Copy Markdown

@dillten dillten commented Apr 27, 2026

Adds M900 legacy model to the models list.

Summary by CodeRabbit

  • New Features
    • Added support for IEEE 802.11n/NG wireless mode.
    • Extended device model recognition for NanoStation loco M900.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2026
@sonarqubecloud
Copy link
Copy Markdown

@dosubot dosubot Bot added the enhancement New feature or request label Apr 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Walkthrough

Two minimal data entries are added to the codebase: an IEEE 802.11n/NG mode enum value (11NGHT20) and a device model-to-SKU mapping for "NanoStation loco M900". No functional logic changes introduced.

Changes

Cohort / File(s) Summary
IEEE Mode Enumeration
airos/data.py
Added new IeeeMode enum member _11NGHT20 with value "11NGHT20" to recognize additional IEEE 802.11n/NG mode variants.
Device Model Mapping
airos/model_map.py
Added manual model-to-SKU mapping entry for device model "NanoStation loco M900 " resolving to SKU "LocoM900".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A mode and a model join the fold,
Two simple lines of config gold,
The NanoStation finds its place,
While 11NGHT20 joins the race! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes both main changes: adding NanoStation loco M900 support to model mapping and IeeeMode enumeration, matching the actual file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@airos/model_map.py`:
- Line 88: The dict in model_map contains a key "NanoStation loco M900 " with a
trailing space which causes mismatches in get_sku_by_devmodel and leaks from
get_devmodel_by_sku; remove the stray trailing space from the key so it becomes
"NanoStation loco M900" to restore exact-match O(1) lookups and prevent the
SKU->devmodel getter from returning a padded string, ensuring other sibling keys
(e.g., "NanoStation loco M5") remain unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1ad0f13c-f4ff-49c2-a6f0-25c14cb94c3a

📥 Commits

Reviewing files that changed from the base of the PR and between 1e3cb9a and 72c1446.

📒 Files selected for processing (2)
  • airos/data.py
  • airos/model_map.py

Comment thread airos/model_map.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant