London | 26-ITP-January | Mouawia Elkhalifa | Sprint 2 | Book Library#414
Open
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Mouawia Elkhalifa | Sprint 2 | Book Library#414MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
MouawiaElkhalifa
force-pushed
the
feature/book-library
branch
from
3635d7d to
23e1f66
Compare
MouawiaElkhalifa
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
MouawiaElkhalifa
force-pushed
the
feature/book-library
branch
from
23e1f66 to
cfd4ac1
Compare
MouawiaElkhalifa
added
the
Needs Review
cjyuan
reviewed
Apr 10, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
MouawiaElkhalifa
added
Needs Review
Author
|
Refactored the script to ensure proper data types, improved variable naming, and resolved the accessibility issues |
MouawiaElkhalifa
added
the
Needs Review
cjyuan
reviewed
Apr 10, 2026
| @@ -1,47 +1,23 @@ | |||
| let myLibrary = []; | |||
Contributor
There was a problem hiding this comment.
Could consider declaring myLibrary using const, since it is not going to be reassigned another value.
Comment on lines
+32
to
37
| const pagesValue = parseInt(pagesInput.value); | ||
|
|
||
| if (!titleValue || !authorValue || isNaN(pagesValue)) { | ||
| alert("Please fill all fields with valid information!"); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
What range of whole numbers are considered valid?
| deleteBtn.addEventListener("click", () => { | ||
| myLibrary.splice(index, 1); | ||
| render(); | ||
| setTimeout(() => alert(`Deleted: ${book.title}`), 100); |
Contributor
There was a problem hiding this comment.
Nice touch to prevent the alert dialog box from blocking the UI update.
cjyuan
removed
the
Needs Review
Contributor
|
Note: In the PR description, the checkboxes and the "Changelist" header are not yet properly encoded in Markdown syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[x] My changes meet the requirements of the task
[x] I have tested my changes
[x] My changes follow the style guide
Changelist
In this PR, I have completed the Book Library debugging exercise.