Skip to content

fix(internal): do not mutate actual config for flare emission#18155

Open
KowalskiThomas wants to merge 2 commits into
mainfrom
kowalski/fix-internal-do-not-mutate-actual-config-for-flare-emission
Open

fix(internal): do not mutate actual config for flare emission#18155
KowalskiThomas wants to merge 2 commits into
mainfrom
kowalski/fix-internal-do-not-mutate-actual-config-for-flare-emission

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

Description

This fixes a bug where the live tracer configuration was mutated when redacting the API key before writing the flare diagnostic file. This meant that any subsequent use of the API key in the configuration file would not work (since the API key was broken).

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 19, 2026

Codeowners resolved as

ddtrace/internal/flare/flare.py                                         @DataDog/apm-core-python
tests/internal/test_tracer_flare.py                                     @DataDog/apm-core-python

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented May 19, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

System Tests | tracer-release / End-to-end #4 / flask-poc 4   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Healthcheck failed for weblog: curl: (28) Operation timed out after 2002 milliseconds with 0 bytes received. Worker process timed out, leading to exit code 1.

System Tests | tracer-release / End-to-end #4 / uds-flask 4   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Worker timeout in container weblog after multiple retries. Could not reach service: connection timed out.

System Tests | tracer-release / End-to-end #6 / django-poc 6   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Healthcheck failed for weblog: curl: (28) Operation timed out after 2002 milliseconds with 0 bytes received.

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b5aeda5 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 19, 2026

Benchmarks

Benchmark execution time: 2026-05-20 15:41:43

Comparing candidate commit b5aeda5 in PR branch kowalski/fix-internal-do-not-mutate-actual-config-for-flare-emission with baseline commit a6282d1 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 371 metrics, 9 unstable metrics.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.681µs; +1.870µs] or [+8.283%; +9.214%]

scenario:span-start

  • 🟥 execution_time [+1.541ms; +1.670ms] or [+9.982%; +10.818%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+248.988ns; +283.316ns] or [+12.016%; +13.673%]

@KowalskiThomas KowalskiThomas force-pushed the kowalski/fix-internal-do-not-mutate-actual-config-for-flare-emission branch from fd69480 to c8ae037 Compare May 19, 2026 14:26
@KowalskiThomas KowalskiThomas marked this pull request as ready for review May 20, 2026 12:01
@KowalskiThomas KowalskiThomas requested review from a team as code owners May 20, 2026 12:01
Copy link
Copy Markdown
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression test?

@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

@brettlangdon added a regression test, thanks for suggesting.

@KowalskiThomas KowalskiThomas force-pushed the kowalski/fix-internal-do-not-mutate-actual-config-for-flare-emission branch from fa51df4 to b5aeda5 Compare May 20, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants