fix(internal): do not mutate actual config for flare emission#18155
Open
KowalskiThomas wants to merge 2 commits into
Open
fix(internal): do not mutate actual config for flare emission#18155KowalskiThomas wants to merge 2 commits into
KowalskiThomas wants to merge 2 commits into
Conversation
Codeowners resolved as |
Contributor
|
BenchmarksBenchmark execution time: 2026-05-20 15:41:43 Comparing candidate commit b5aeda5 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 371 metrics, 9 unstable metrics. scenario:httppropagationinject-ids_only
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
fd69480 to
c8ae037
Compare
Contributor
Author
|
@brettlangdon added a regression test, thanks for suggesting. |
brettlangdon
approved these changes
May 20, 2026
fa51df4 to
b5aeda5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where the live tracer configuration was mutated when redacting the API key before writing the flare diagnostic file. This meant that any subsequent use of the API key in the configuration file would not work (since the API key was broken).