Skip to content

chore: enable strict typing for threads#18158

Draft
P403n1x87 wants to merge 1 commit into
mainfrom
chore/threads-strict-typing
Draft

chore: enable strict typing for threads#18158
P403n1x87 wants to merge 1 commit into
mainfrom
chore/threads-strict-typing

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We enable strict typing checks for the native threads module.

We enable strict typing checks for the native threads module.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label May 19, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/internal/_threads.pyi                                           @DataDog/apm-core-python
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python

@datadog-prod-us1-4
Copy link
Copy Markdown
Contributor

datadog-prod-us1-4 Bot commented May 19, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 33293e8 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 19, 2026

Benchmarks

Benchmark execution time: 2026-05-19 12:58:10

Comparing candidate commit 33293e8 in PR branch chore/threads-strict-typing with baseline commit ddab0a7 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 584 metrics, 10 unstable metrics.

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+56.139µs; +60.262µs] or [+20.866%; +22.398%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+43.627µs; +56.315µs] or [+8.873%; +11.454%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+103.389µs; +110.934µs] or [+24.273%; +26.044%]

scenario:span-start

  • 🟥 execution_time [+1.352ms; +1.485ms] or [+8.648%; +9.501%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+274.841ns; +297.491ns] or [+13.457%; +14.566%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant