Skip to content

Create website-boost.com.connect.json#1016

Open
website-boost wants to merge 2 commits into
Domain-Connect:masterfrom
website-boost:master
Open

Create website-boost.com.connect.json#1016
website-boost wants to merge 2 commits into
Domain-Connect:masterfrom
website-boost:master

Conversation

@website-boost
Copy link
Copy Markdown

@website-boost website-boost commented Apr 18, 2026

Description

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

Test link could not be generated — exampleservice.domainconnect.org/simple returns 404 (service appears to be down). Template has been manually validated. Happy to provide additional testing if needed.

@github-actions github-actions Bot added hostRequired hostRequired is set Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. syncBlock syncBlock is set for the template labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

JSON Filename Check Passed

@github-actions github-actions Bot added PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

JSON Schema Validation Failed

Details
Checking schema for website-boost.com.connect.json
Schema validation errors were encountered.
  website-boost.com.connect.json::$.syncBlock: [{'type': 'CNAME', 'host': '%host%', 'pointsTo': 'website-boost-router.muddy-mode-170d.workers.dev', 'ttl': 300}] is not of type 'boolean'
  website-boost.com.connect.json::$: 'records' is a required property

@github-actions github-actions Bot added the schema-error JSON Schema validation failed label Apr 18, 2026
@github-actions
Copy link
Copy Markdown

Linter error

website-boost.com.connect.json

Level Code Note
error DCTL0003 json error

@github-actions github-actions Bot removed the Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. label Apr 18, 2026
@github-actions
Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 4/10 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete, Forged editor links

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 1/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: website-boost.com.connect.json: no editor test link found (expected template id 'website-boost.com.connect')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. schema-error JSON Schema validation failed syncBlock syncBlock is set for the template Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant