Bug fix: update public headers in expui/CMakeLists.txt to fix gala compatibility#218
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes downstream build failures (e.g., gala with EXP v7.9.3) by ensuring all required public headers for EXP’s installed interface are included in the expui public header install set.
Changes:
- Add
Covariance.HandExpDeproj.Htoexpui’sPUBLIC FILE_SET HEADERSso they get installed underinclude/EXP.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
No additional testing necessary on for EXP since this change only affects downstream library integration. This will be tested in part by EXP-code/EXP-container#21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to build gala with EXP support using v7.9.3 failed with errors stating the build could not find the header files Covariance.H and ExpDeproj.H.
Per @The9Cat , added these header files to expui/CmakeLists.txt. This fixes the issue and allows gala to be built with EXP 7.9.3.