Fix ReferenceError: indexedDB is not defined during SSR#140
Fix ReferenceError: indexedDB is not defined during SSR#140Adebesin-Cell merged 2 commits intomainfrom
ReferenceError: indexedDB is not defined during SSR#140Conversation
🦋 Changeset detectedLatest commit: 2a9c9ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @Adebesin-Cell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue causing application crashes during server-side rendering by preventing the initialization of browser-specific APIs in a Node.js environment. The change ensures that components requiring client-side capabilities are only instantiated when the application is running in a browser, thereby stabilizing the SSR process and eliminating runtime errors related to undefined browser objects. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a server-side rendering crash by preventing wagmi connectors from being initialized in a non-browser environment. The approach of checking for typeof window !== "undefined" is appropriate. I've added one comment regarding the unconditional creation of web3AuthInstance, which might also need to be guarded to make the SSR behavior fully robust, as Web3Auth libraries often require special handling for SSR.
Closes https://github.com/EveripediaNetwork/issues/issues/4705 when this PR merged
Related:
Description
This PR fixes a server-side rendering (SSR) crash caused by browser-only APIs being accessed during server execution.
The issue occurred when wagmi connectors were initialized during SSR. Since APIs like
indexedDBare not available in a Node.js environment, this resulted in aReferenceErrorand caused Next.js to fail during server rendering.To resolve this, connector initialization is now gated to run only in the browser.
Summary of Changes
Result
ReferenceError: indexedDB is not defined.Closes