Skip to content

Fix conflict ImplosionRecipe#364

Merged
tier940 merged 2 commits intomasterfrom
tier-fix-conflict
Apr 19, 2026
Merged

Fix conflict ImplosionRecipe#364
tier940 merged 2 commits intomasterfrom
tier-fix-conflict

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 19, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 19, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the recipe registration logic for implosion processes by removing conditional handling for external mods. It also improves recipe stability by ensuring conflicting Macerator recipes are properly removed before new ones are registered.

Highlights

  • Refactoring Implosion Recipe Handling: Removed the dependency on the ImplosionNoBomb mod and simplified the GTEImplosionRecipeHandler to use a unified registration process.
  • Recipe Cleanup: Added explicit removal of existing Macerator recipes for Dragon Eggs and Chaos Shards to prevent conflicts during recipe registration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストでは、DraconicMaterialsRecipe における既存レシピの削除処理の追加と、不要になった Implosion No Bomb 関連のロジックおよびクラスの削除が行われました。レビューでは、GTEImplosionRecipeHandler の register メソッドを public に公開し、他のクラスでのコード再利用性を向上させる提案が行われています。

@tier940 tier940 merged commit 56a0527 into master Apr 19, 2026
0 of 2 checks passed
@tier940 tier940 deleted the tier-fix-conflict branch April 19, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant