feat(4/5): add SelectEmployees container for holiday pay policies (SDK-567) by jeffredodd · Pull Request #1616 · Gusto/embedded-react-sdk

jeffredodd · 2026-04-27T17:32:56Z

Summary

Adds SelectEmployeesHoliday container component for holiday pay policies
Fetches employees via useEmployeesListSuspense with pagination
Fetches holiday policy data (version field required by PUT endpoint) via useHolidayPayPoliciesGetSuspense
Supports standalone mode (calls useHolidayPayPoliciesAddEmployeesMutation directly) and wizard mode (emits TIME_OFF_HOLIDAY_ADD_EMPLOYEES_DONE event)
Client-side search filtering across the current page of results

Test plan

npm run test -- --run src/components/UNSTABLE_TimeOff/TimeOffManagement/SelectEmployees/SelectEmployeesHoliday
Storybook: verify SelectEmployeesPresentation stories still render (holiday uses same presentation layer)
In sdk-app: navigate to UNSTABLE_TimeOff → AddEmployeesHoliday and verify employee list loads

Part of stacked PR series for SDK-567:

PR 1: feat/text-input-employee-table-search → main
PR 2: feat/select-employees-presentation → PR 1
PR 3: feat/select-employees-time-off → PR 2
PR 4 (this PR): feat/select-employees-holiday → PR 3
PR 5: feat/select-employees-flow-integration → PR 4

🤖 Generated with Claude Code

serikjensen · 2026-04-29T21:54:33Z

+  const filteredEmployees = useMemo(() => {
+    if (!searchValue) return employees
+    const lower = searchValue.toLowerCase()
+    return employees.filter(e =>
+      `${e.firstName ?? ''} ${e.lastName ?? ''}`.toLowerCase().includes(lower),
+    )
+  }, [employees, searchValue])


Seeing some of these repeated across the PRs, there may be opportunities for shared utils?

Good call — extracted a useSelectEmployeesData hook that consolidates the employee list fetching, mapping, filtering, pagination, selection state, and search handlers that were duplicated across both containers. Both SelectEmployeesHoliday and SelectEmployeesTimeOff now call into it.

serikjensen

Seems like there's some duplication here that we may be able to consolidate with a shared hook or utils. i trust you'll be able to resolve that

serikjensen · 2026-04-29T21:55:04Z

+  const handleContinue = useCallback(async () => {
+    if (mode === 'wizard') {
+      onEvent(componentEvents.TIME_OFF_HOLIDAY_ADD_EMPLOYEES_DONE, {
+        employeeUuids: [...selectedUuids],
+      })
+      return
+    }
+
+    await baseSubmitHandler({}, async () => {
+      await addEmployees({
+        request: {
+          companyUuid: companyId,
+          requestBody: {
+            version: policyData.holidayPayPolicy?.version ?? '',
+            employees: [...selectedUuids].map(uuid => ({ uuid })),
+          },
+        },
+      })
+      onEvent(componentEvents.TIME_OFF_HOLIDAY_ADD_EMPLOYEES_DONE)
+    })
+  }, [mode, baseSubmitHandler, addEmployees, companyId, policyData, selectedUuids, onEvent])


actually this feels extremely similar to the last one i looked at 🤔

Yep, same shape entirely. Refactored both containers to use useSelectEmployeesData — the shared hook now owns all the common logic and each container is left with only its policy-specific mutation and continue handler.

serikjensen · 2026-04-29T21:55:21Z

+          },
+        },
+      })
+      onEvent(componentEvents.TIME_OFF_HOLIDAY_ADD_EMPLOYEES_DONE)


Same feedback here where we might consider passing the result of the add employees call

Done — now captures the result and passes result.holidayPayPolicy to onEvent, matching the existing response.timeOffPolicy pattern in SelectEmployeesTimeOff.

…arch - Add min, max, maxLength passthrough props to Input and TextInput - Add search input with inline clear button to EmployeeTable - Add isFetching loading state and pagination support to EmployeeTable Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Removes the absolutely-positioned custom clear button and its SCSS. The browser's built-in search cancel button is now used, which works naturally with component adapter overrides since type is a standard HTML attribute forwarded by any TextInput implementation. Bridges native clear (fires onChange('')) to onSearchClear so pagination resets in consumers remain intact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fetches active employees and the holiday pay policy (for the required version field), manages selection/search/pagination state, and calls useHolidayPayPoliciesAddEmployeesMutation on Continue in standalone mode. In wizard mode, emits TIME_OFF_HOLIDAY_ADD_EMPLOYEES_DONE with selected UUIDs. No starting balance column (holiday policies don't support it) and no reassignment warning (employees can be in both holiday and time-off policies simultaneously). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…yees containers - Extract useSelectEmployeesData hook consolidating employee list fetching, mapping, filtering, pagination, selection, and search state shared between SelectEmployeesHoliday and SelectEmployeesTimeOff - Pass result.holidayPayPolicy to onEvent in SelectEmployeesHoliday standalone mode, matching the existing pattern in SelectEmployeesTimeOff - Wrap SelectEmployeesTimeOff handleContinue in useCallback Addresses code duplication and result-passing feedback from PR #1616 review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Adds a holiday-pay-policy “Select Employees” container and refactors shared employee-list selection/search/pagination logic into a reusable hook, along with tests and endpoint inventory/docs updates for the new holiday add-employees endpoint.

Changes:

Introduces SelectEmployeesHoliday container with standalone vs wizard mode behavior.
Extracts shared employees list + selection + search + pagination logic into useSelectEmployeesData and updates SelectEmployeesTimeOff to use it.
Adds SelectEmployeesHoliday unit tests and updates endpoint reference/inventory to include the holiday add endpoint.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/components/UNSTABLE_TimeOff/TimeOffManagement/SelectEmployees/useSelectEmployeesData.ts	New shared hook for paginated employees fetch, selection state, and search filtering.
src/components/UNSTABLE_TimeOff/TimeOffManagement/SelectEmployees/SelectEmployeesTimeOff.tsx	Refactors Time Off container to use the shared hook and simplifies search/selection wiring.
src/components/UNSTABLE_TimeOff/TimeOffManagement/SelectEmployees/SelectEmployeesHoliday.tsx	New Holiday container that fetches holiday policy version and adds employees (or emits wizard event).
src/components/UNSTABLE_TimeOff/TimeOffManagement/SelectEmployees/SelectEmployeesHoliday.test.tsx	New tests covering holiday selection UI, standalone mutation behavior, and wizard event behavior.
docs/reference/endpoint-reference.md	Adds the holiday add-employees PUT endpoint to the UNSTABLE_TimeOff endpoint tables.
docs/reference/endpoint-inventory.json	Adds the holiday add-employees PUT endpoint to the endpoint inventory entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+      const result = await addEmployees({
+        request: {
+          companyUuid: companyId,
+          requestBody: {
+            version: policyData.holidayPayPolicy?.version ?? '',


+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [employeesData.httpMeta.response.headers, isFetching, currentPage, itemsPerPage],


jeffredodd changed the title ~~feat: add SelectEmployees container for holiday pay policies (SDK-567)~~ feat(4/5): add SelectEmployees container for holiday pay policies (SDK-567) Apr 27, 2026

jeffredodd force-pushed the feat/select-employees-time-off branch from fcbf391 to 63e1327 Compare April 27, 2026 20:23

jeffredodd force-pushed the feat/select-employees-holiday branch from 55b3ce9 to 28d57da Compare April 27, 2026 20:24

jeffredodd force-pushed the feat/select-employees-time-off branch from 63e1327 to 1cc43ea Compare April 27, 2026 20:33

jeffredodd force-pushed the feat/select-employees-holiday branch from 28d57da to de815ad Compare April 27, 2026 20:37

jeffredodd force-pushed the feat/select-employees-time-off branch from 1cc43ea to 533317d Compare April 27, 2026 21:52

jeffredodd force-pushed the feat/select-employees-holiday branch from de815ad to d89a746 Compare April 27, 2026 21:52

jeffredodd force-pushed the feat/select-employees-time-off branch from 533317d to 73686e3 Compare April 27, 2026 21:55

jeffredodd force-pushed the feat/select-employees-holiday branch from d89a746 to 270f050 Compare April 27, 2026 21:55

jeffredodd force-pushed the feat/select-employees-time-off branch from 73686e3 to c6b5911 Compare April 27, 2026 22:19

jeffredodd force-pushed the feat/select-employees-holiday branch from 270f050 to ba3120e Compare April 27, 2026 22:19

jeffredodd marked this pull request as ready for review April 27, 2026 23:06

jeffredodd requested review from dmortal, hukid, krisxcrash and serikjensen as code owners April 27, 2026 23:06

serikjensen reviewed Apr 29, 2026

View reviewed changes

serikjensen approved these changes Apr 29, 2026

View reviewed changes

jeffredodd force-pushed the feat/select-employees-time-off branch 2 times, most recently from 4afa962 to c0c078a Compare April 30, 2026 15:50

Base automatically changed from feat/select-employees-time-off to main April 30, 2026 15:52

jeffredodd and others added 5 commits April 30, 2026 09:00

fix: update endpoint inventory for SelectEmployeesHoliday API hooks

17843cb

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 30, 2026 16:12

jeffredodd force-pushed the feat/select-employees-holiday branch from ba3120e to a0bd1ad Compare April 30, 2026 16:12

Copilot started reviewing on behalf of jeffredodd April 30, 2026 16:13 View session

jeffredodd merged commit 9a7486b into main Apr 30, 2026
21 checks passed

jeffredodd deleted the feat/select-employees-holiday branch April 30, 2026 16:18

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(4/5): add SelectEmployees container for holiday pay policies (SDK-567)#1616

feat(4/5): add SelectEmployees container for holiday pay policies (SDK-567)#1616
jeffredodd merged 5 commits intomainfrom
feat/select-employees-holiday

jeffredodd commented Apr 27, 2026

Uh oh!

serikjensen Apr 29, 2026

Uh oh!

jeffredodd Apr 30, 2026

Uh oh!

serikjensen left a comment

Uh oh!

serikjensen Apr 29, 2026

Uh oh!

jeffredodd Apr 30, 2026

Uh oh!

serikjensen Apr 29, 2026

Uh oh!

jeffredodd Apr 30, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// eslint-disable-next-line react-hooks/exhaustive-deps
		[employeesData.httpMeta.response.headers, isFetching, currentPage, itemsPerPage],

Conversation

jeffredodd commented Apr 27, 2026

Summary

Test plan

Uh oh!

serikjensen Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

jeffredodd Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

serikjensen left a comment

Choose a reason for hiding this comment

Uh oh!

serikjensen Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

jeffredodd Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

serikjensen Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

jeffredodd Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants