Open
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
There was a problem hiding this comment.
Pull request overview
This PR reduces Cython build warnings in mkl-service by removing redundant/incorrect exception-specifiers (noexcept, except *) from internal Cython helper functions in the MKL wrapper layer.
Changes:
- Remove
noexceptfrom an internal helper that returns a Pythonstr. - Remove
except *from multiple internal helpers that return Python objects/strings.
ndgrigorian
force-pushed
the
fix-cython-build-warnings
branch
from
cd32d6d to
0dfec79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes fixing Cython warnings when building
mkl-servicecaused by unnecessarynoexceptandexcept *declarations