fix: Detect demo-format WS auth ack (success:true) as success (#63)#89
Open
darekurlik wants to merge 1 commit intoJohnnyWic:mainfrom
Open
fix: Detect demo-format WS auth ack (success:true) as success (#63)#89darekurlik wants to merge 1 commit intoJohnnyWic:mainfrom
darekurlik wants to merge 1 commit intoJohnnyWic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebsocketStreamClientImpl.onMessageonly treats"retCode":0as a successful auth ack:Bybit's demo trading private WebSocket (
wss://stream-demo.bybit.com/v5/private) instead responds with:{"req_id":"...","success":true,"ret_msg":"","op":"auth","conn_id":"..."}No
retCodefield → lib reports"Authentication failed."and never flushes queued private subscriptions (order/position/execution/wallet), leaving the WS open but useless.This is the same issue reported in #63.
Fix
Accept either signal as auth success:
Mainnet acks (which include
retCode:0) keep working unchanged.Verified
End-to-end against real Bybit demo with valid demo credentials:
Closes #63.