Case-sensitive sorting#45
Open
nchilada wants to merge 3 commits intoJuliaEditorSupport:masterfrom
Open
Conversation
Author
|
Addresses #44 |
Author
|
TODO: unit tests as well as manual end-to-end tests in VS Code. EDIT: done. |
Author
|
This still deserves automated tests, but I've confirmed that it works like a charm locally, at least for my basic use case. I'm ready for feedback! |
nchilada
changed the title
Also bring the EcmaScript version a bit more up to date, thereby allowing the use of `Object.entries`.
nchilada
force-pushed
the
nchilada/case-sensitive-sorting
branch
from
965a619 to
7b93f2f
Compare
Author
|
Automated unit tests are done. Automated integration tests feel a bit outside my remit, so I hope whoever eventually reviews this PR (or at least whoever performs the next release to the Marketplace?) will be willing to do a quick manual test to double-check that nothing's been horrifically broken... 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching for e.g. lowercase
omegashould result in lowercase\omegaand its variants appearing prior to the corresponding uppercase\Omegasymbols:while searching for uppercase
Omegashould result in uppercase\Omegaand its variants appearing prior to the corresponding lowercase\omegasymbols: