Skip to content

RSS Restructure#320

Open
PhineasFreak wants to merge 55 commits intomasterfrom
restructure
Open

RSS Restructure#320
PhineasFreak wants to merge 55 commits intomasterfrom
restructure

Conversation

@PhineasFreak
Copy link
Copy Markdown

@PhineasFreak PhineasFreak commented Apr 19, 2026

Major update for RSS to try and bring it up to current KSP and Kopernicus standards:

  • Should mostly be a non save-breaking update.
  • Complete restructure of the directory tree (built upon Restructure Folders #306).
  • All mod compatibility patches now reside under the (existing) "Compatibility" directory.
  • All RSS-specific patches now reside under the "Config" directory.
  • All RSS-specific patches are now prefixed with "RSS_".
  • All Kopernicus body cache files are now stored under the "PluginData/KopernicusCache" path.
  • Added navball switching handling for "altitude" and "atmosphereDepth" options (from Fixed some compatibility issues #286).
  • Renamed the KSCSwitcher patch from "LaunchSites" to "KSCSwitcher".
  • Renamed the NIMBY patch from "RecoveryBeacons" to "NIMBY".
  • Removed all PQS mods from the Earth (simplifies removal of various useless PQSCity mods).
  • Removed the "cbNameLater" parameter from the Earth. 💯
  • Removed the stock launch sites introduced with KSP version 1.12 ("Glacier Lake", "Cove", "Mahi Mahi", "Crater").
  • Removed support for the "FinalFrontier" mod.
  • Removed support for the "RemoteTech" mod (use https://github.com/DRVeyl/RealAntennas).
  • Removed support for the "PlanetShine" mod (use https://github.com/LGhassen/Deferred).
  • Updated the SS body texture definitions to the use the newer OnDemand{} nodes for loading.
  • Updated the Pluto and Charon rotation period to use hard-coded values (RSS now uses gravitational parameters for all bodies).
  • Updated the Triton rotation period to use a hard-coded value (RSS now uses gravitational parameters for all bodies).
  • Updated the Earth and Titan oceans to use custom settings for for better visuals.
  • Separated the SigmaBinary patch for the Pluto/Charon system to its own file.
  • Added fallback PQS materials wherever applicable (not really necessary but good to have).
  • Updated the Saturn rings to use the new Kopernicus ring shader.

Bug Fixes:

  • Increased the space high threshold for Earth from 35786 km to 40000 km (see Change Earth High Space boundary #313).
  • Decreased the flying high threshold for Earth from 50 km to 40 km (matches the RP-1 value).
  • Increased the camera far clipping planes from ~1.9 Mm to 3 Mm (ported from RSSVE).
  • Fixed the Sun light parameters for compatibility with the newer Kopernicus versions.
  • Fixed the CommNet patch being unable handle parts with more that one "ModuleDataTransmitter" modules.
  • Fixed the science definitions for compatibility with the newer Module Manager versions (Update ScienceDefs.cfg #315).
  • Fixed the Venus, Earth, Mars and Titan AFG parameters for smoother edges.
  • Fixed the overexposed specular reflections of all gas giants.
  • Fixed the TextureReplacer compatibility patch to edit the existing node instead of creating a new one (might confuse other mods that search for that node).
  • Fixed the hard-coded description localization for Oberon and Umbriel.
  • Fixed the PQS/SS transition altitudes of Ceres, Vesta, Miranda, Ariel, Umbriel, Titania and Oberon.
  • Fixed the grass color and texture tiling of the KSC buildings.
  • Fixed the incorrect, relative to Pluto, osculating elements of Charon.
  • Fixed the missing AFG nodes of Neptune, Triton and Pluto.
  • Removed a duplicate gravitational parameter in the Titan config overriding the proper one.
  • Tweaked the brightness matching between PQS and SS transition for all bodies.
  • Reverted many PQS material nodes to use stock KSP terrain detail textures instead of the RSS-supplied ones (workaround until they are fixed).
  • Removed the custom PQS terrain quality settings from all bodies (possibly overriding the newer terrain presets).

Known Issues:

  • The oblate feature for the gas giants does not work (probable Kopernicus bug).
  • The KSC monolith anomaly cannot be removed (it is part of the space center mesh).
  • The Sun has the stock yellow appearance instead of being white.
  • Some RSS terrain detail textures have incorrect glossiness factors.

Other Notes:

Rename file
Implement bugfix #315
Also update the MM deletion operations to apply to all nodes found.
Now depends upon the base TR configuration file instead of creating a phantom one.
Also update the ModuleDataTransmitter pass to apply to all such modules found in a given part.
Also increase the far camera clip plane to 3 Mm (change ported from RSSVE)
Also add compatibility for the "altitude" and "atmosphereDepth" parameters (pull #286)
None of these files has been modified.
Remove the "cbNameLater" parameter.
Remove all PQSCity mods.
Remove the deprecated "lightColor" parameter.
Remove the deprecated "lightColor" parameter.
Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter.
Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter.
Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter.
Cleanup the oblate patch.
Consolidate the tidal locking patch to the main configuration file since the gravitational parameter is now a fixed number.
Principia compatibility remains unchanged.
Consolidate the tidal locking patch to the main configuration file since the gravitational parameter is now a fixed number.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Download the artifacts for this pull request:

// inconsistent orbital elements.

!Body,* {}
!Body,*{}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bothered me when I saw it. Still does. It is critical that this patch runs before all other patches that add a Body node. Previously it relied on the lexicographical ordering: RealSolarSystem/RSSKopernicusSettings.cfg before RealSolarSystem/RSSKopernicus/. The "/" sorting after A-Z.

You don't have that pattern now. You have Config/RSS_Kopernicus.cfg compared with Config/Earth/. I didn't think MM patch ordering had a file-before-folder pattern, I thought it was strictly lexicographical.

My suggestion is move this patch to BEFORE[RealSolarSystem], making it clear and giving you a more obvious sorting of this setup patch versus the global ones.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very valid point and it should be a BEFORE pass even without name shorting (stock KSP mods use AFTER[Kopernicus] for example).

@PhineasFreak
Copy link
Copy Markdown
Author

If anyone around here is knownledgable about how textures are set up for use in KSP please do chime in. The terrain detail textures RSS includes have a very shiny-like, almost glossy appearance, which is...suboptimal.

* Further tweaks to all AFGs to soften the edges.
* Update SS atmosphere gradients.
* Add rarified atmosphere effects to Triton and Pluto.
* Ocean color tweaks for Earth and Titan.
* Add fallback ocean materials.
* Increase Earth ocean fade distance.
* Make Jupiter, Uranus and Neptune a bit less washed out.
* Make Mars and Saturn a bit paler.
* Force the use of the much better quality PQS at higher altitudes (might need further adjustments).
Copy link
Copy Markdown

@Clayell Clayell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this change would make this PR save breaking?
(github messed up the comment, this is referring to the cbNameLater commit)

@PhineasFreak PhineasFreak requested a review from Clayell April 21, 2026 06:31
@PhineasFreak
Copy link
Copy Markdown
Author

PhineasFreak commented Apr 21, 2026

As weird as it sounds, no! 100% drop-in replacement. Well, the Titan body configuration had a duplicate GM factor with less precision that overrode the proper one so there might be a very slight difference in the orbit (8.978138376543E+12 vs 8.9778648E+12, 0.00305%).

Edit 1: I could make a save-breaking change by reordering the body indices.

Edit 2: OK, I will break saves, I corrected the height offset of Vesta and Ceres when transitioning between PQS/SS (any landed vessels will float above the surface).

@Clayell
Copy link
Copy Markdown

Clayell commented Apr 21, 2026

If it is save breaking, then AssemblyInfo.cs can/should probably be updated as well. It's still reading 18.5.0.0!
I'm also surprised to see that there's no KSPAssembly attribute, which allows for other mods to declare a KSPAssemblyDependency on RSS. Can this be added?

@PhineasFreak
Copy link
Copy Markdown
Author

I guess so, I am not well-versed with the C# side of KSP and mods (and should be done in a separate commit).

@PhineasFreak
Copy link
Copy Markdown
Author

Poll: since there will be some save-breaking changes, would this be a good opportunity to remove all "flightGlobalsIndex" definitions?

@siimav
Copy link
Copy Markdown

siimav commented Apr 25, 2026

There's different levels of save breakage. Pretty much nobody's going to care about vessels landed on Ceres. However every probe around every body getting deleted is a serious issue.

* Prepare the body configuration for the new texture maps.
* Move the required PQS mods to RSS itself.
* Add a missing science recovery parameter.
* Add some extra PQS noise.
* Prepare the Pluto body configuration for the new texture maps.
* Move the required PQS mods to RSS itself.
* Fix the incorrect Charon osculating elements.
* Fix the initial rotation of Pluto.
* Reduce the Pluto height deformity to better conform to newer topographic maps.
* Prepare the body configuration for the new texture maps.
* Move the required PQS mods to RSS itself.
* Add a height map.
* They break the PQS/SS transition near the horizon and make the body surface appear lower than it should.
* Make sure that the PQS mods apply in the same order as before.
* Disable SS spherical model.
@PhineasFreak
Copy link
Copy Markdown
Author

For the above changes add the following textures: https://github.com/PhineasFreak/RSS-Textures-Dev/releases/tag/v0.1.0

Select your pack according to the already installed RSS textures. Replace when asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants