Conversation
Rename file Implement bugfix #315
Also update the MM deletion operations to apply to all nodes found.
Now depends upon the base TR configuration file instead of creating a phantom one.
Also update the ModuleDataTransmitter pass to apply to all such modules found in a given part.
Also increase the far camera clip plane to 3 Mm (change ported from RSSVE)
Also add compatibility for the "altitude" and "atmosphereDepth" parameters (pull #286)
None of these files has been modified.
Remove the "cbNameLater" parameter. Remove all PQSCity mods. Remove the deprecated "lightColor" parameter.
Remove the deprecated "lightColor" parameter. Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter. Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter. Cleanup the oblate patch.
Remove the deprecated "lightColor" parameter. Cleanup the oblate patch.
Consolidate the tidal locking patch to the main configuration file since the gravitational parameter is now a fixed number. Principia compatibility remains unchanged.
Consolidate the tidal locking patch to the main configuration file since the gravitational parameter is now a fixed number.
|
Download the artifacts for this pull request: |
| // inconsistent orbital elements. | ||
|
|
||
| !Body,* {} | ||
| !Body,*{} |
There was a problem hiding this comment.
This bothered me when I saw it. Still does. It is critical that this patch runs before all other patches that add a Body node. Previously it relied on the lexicographical ordering: RealSolarSystem/RSSKopernicusSettings.cfg before RealSolarSystem/RSSKopernicus/. The "/" sorting after A-Z.
You don't have that pattern now. You have Config/RSS_Kopernicus.cfg compared with Config/Earth/. I didn't think MM patch ordering had a file-before-folder pattern, I thought it was strictly lexicographical.
My suggestion is move this patch to BEFORE[RealSolarSystem], making it clear and giving you a more obvious sorting of this setup patch versus the global ones.
There was a problem hiding this comment.
That is a very valid point and it should be a BEFORE pass even without name shorting (stock KSP mods use AFTER[Kopernicus] for example).
|
If anyone around here is knownledgable about how textures are set up for use in KSP please do chime in. The terrain detail textures RSS includes have a very shiny-like, almost glossy appearance, which is...suboptimal. |
* Further tweaks to all AFGs to soften the edges. * Update SS atmosphere gradients. * Add rarified atmosphere effects to Triton and Pluto. * Ocean color tweaks for Earth and Titan. * Add fallback ocean materials. * Increase Earth ocean fade distance.
* Make Jupiter, Uranus and Neptune a bit less washed out. * Make Mars and Saturn a bit paler.
* Force the use of the much better quality PQS at higher altitudes (might need further adjustments).
|
As weird as it sounds, no! 100% drop-in replacement. Well, the Titan body configuration had a duplicate GM factor with less precision that overrode the proper one so there might be a very slight difference in the orbit (8.978138376543E+12 vs 8.9778648E+12, 0.00305%). Edit 1: I could make a save-breaking change by reordering the body indices. Edit 2: OK, I will break saves, I corrected the height offset of Vesta and Ceres when transitioning between PQS/SS (any landed vessels will float above the surface). |
|
If it is save breaking, then AssemblyInfo.cs can/should probably be updated as well. It's still reading 18.5.0.0! |
|
I guess so, I am not well-versed with the C# side of KSP and mods (and should be done in a separate commit). |
|
Poll: since there will be some save-breaking changes, would this be a good opportunity to remove all "flightGlobalsIndex" definitions? |
|
There's different levels of save breakage. Pretty much nobody's going to care about vessels landed on Ceres. However every probe around every body getting deleted is a serious issue. |
* Prepare the body configuration for the new texture maps. * Move the required PQS mods to RSS itself. * Add a missing science recovery parameter. * Add some extra PQS noise.
* Prepare the Pluto body configuration for the new texture maps. * Move the required PQS mods to RSS itself. * Fix the incorrect Charon osculating elements. * Fix the initial rotation of Pluto. * Reduce the Pluto height deformity to better conform to newer topographic maps.
* Prepare the body configuration for the new texture maps. * Move the required PQS mods to RSS itself. * Add a height map.
* They break the PQS/SS transition near the horizon and make the body surface appear lower than it should.
* Make sure that the PQS mods apply in the same order as before. * Disable SS spherical model.
Ideally...
|
For the above changes add the following textures: https://github.com/PhineasFreak/RSS-Textures-Dev/releases/tag/v0.1.0 Select your pack according to the already installed RSS textures. Replace when asked. |
Major update for RSS to try and bring it up to current KSP and Kopernicus standards:
Bug Fixes:
Known Issues:
Other Notes: