Add mgmtsystem_security_event module for Odoo 18.0#763
Open
Add mgmtsystem_security_event module for Odoo 18.0#763
Conversation
etobella
requested changes
Dec 15, 2025
Member
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
A few things. It was a migration of which module?
I only found one with the same name on v8. If that is the case, you didn't follow the migration guide.
Also, use proper commit names please, leave the migration on a single commit (or adding if it is not a migration) and review pre-commit and tests.
Author
|
Sorry, it is the migration of mgmtsystem_security_event to v18.
there is no mgmtsystem_security_event on v18 branch.
El lun, 15 dic 2025 a las 11:49, Enric Tobella ***@***.***>)
escribió:
… ***@***.**** requested changes on this pull request.
A few things. It was a migration of which module?
I only found one with the same name on v8. If that is the case, you didn't
follow the migration guide.
Also, use proper commit names please, leave the migration on a single
commit (or adding if it is not a migration) and review pre-commit and tests.
—
Reply to this email directly, view it on GitHub
<#763 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6CVGGJCR5L3X5UJA6C53T4B3DANAVCNFSM6AAAAACOVM5XD2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNZYGYYDCOBXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
In that case, you didn't follow the migration styles and your CI is failing. |
Author
|
Ok Sorry, will try to fix it as soon as I get the time.
El mar, 16 dic 2025 a las 10:33, Enric Tobella ***@***.***>)
escribió:
… *etobella* left a comment (OCA/management-system#763)
<#763 (comment)>
In that case, you didn't follow the migration styles and your CI is
failing.
—
Reply to this email directly, view it on GitHub
<#763 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6CVGDHH4QT5NDBPF4OQK34CACY5AVCNFSM6AAAAACOVM5XD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRQGU2DANJTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I migrated this module into 18.0
I'm submitting it for review. It works as far as I tested it.
Thanks
Hector Quiroz
Trixocom