Skip to content

[19.0][MIG]: endpoint#127

Merged
OCA-git-bot merged 70 commits intoOCA:19.0from
Studio73:19.0-mig-endpoint
Apr 29, 2026
Merged

[19.0][MIG]: endpoint#127
OCA-git-bot merged 70 commits intoOCA:19.0from
Studio73:19.0-mig-endpoint

Conversation

@Alexgars73
Copy link
Copy Markdown

@Alexgars73 Alexgars73 commented Mar 30, 2026

Standard migration

Depends on

simahawk and others added 30 commits March 30, 2026 08:30
By putting the model in the routing handler options
we allow to:

* avoid override of _default_endpoint_options_handler if you only want to search another model
* make explicit in the route configuration the model that will be searched
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-api-14.0/web-api-14.0-endpoint
Translate-URL: https://translation.odoo-community.org/projects/web-api-14-0/web-api-14-0-endpoint/
Comment thread endpoint/models/endpoint_mixin.py Outdated
rec._validate_exec_mode()

def _validate_exec_mode(self):
validator = getattr(self, "_validate_exec__" + self.exec_mode, lambda x: True)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validator = getattr(self, "_validate_exec__" + self.exec_mode, lambda x: True)
validator = getattr(self, "_validate_exec__" + self.exec_mode, lambda: True)

the validator is called without arguments, so the default lambda value shuoldn't take any

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pre-existing bug. can you solve in a separate commit so we can easily backport?

@yankinmax
Copy link
Copy Markdown

Hello @Alexgars73 , will you be able to update and fix this PR soon or I can replace it with another one and speed up the migration process?

@Alexgars73
Copy link
Copy Markdown
Author

@yankinmax i added the change that @ivantodorovich request, the dependency still not merged so we cannot do nothing at moment.

@yankinmax
Copy link
Copy Markdown

@yankinmax i added the change that @ivantodorovich request, the dependency still not merged so we cannot do nothing at moment.

Thanks a lot. I'll try to speed up rpc_helper migration

@yankinmax
Copy link
Copy Markdown

Hey @Alexgars73 the rpc_helper is merged, let's update this one and get it merged 😄

@Alexgars73
Copy link
Copy Markdown
Author

@yankinmax done!

@yankinmax
Copy link
Copy Markdown

Hello @simahawk can you pls trigger a merge here?

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Copy Markdown
Contributor

/ocabot merge nobump
/ocabot migration endpoint

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Apr 29, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-127-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 29, 2026
8 tasks
@OCA-git-bot OCA-git-bot merged commit 83ce013 into OCA:19.0 Apr 29, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a8bd9c5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.