Add overwrite warning for duplicate file uploads (#2679)#5477
Add overwrite warning for duplicate file uploads (#2679)#5477bstepanovski wants to merge 2 commits into
Conversation
|
I'm not sure that I like the idea of stacking the modals on top of one another. It seems like that is a consequence of
But I feel like we should be able to intercept the upload and cancel it without leaving things in a failed state. I could be missing something though. In any case, the modal itself suffers many of the issues noted in #5068. There are two close buttons, the title is not bolded, and the checkbox is part of the main content, when it seems like it would fit better below the dividing line next to the 'cancel' and 'upload' buttons. Finally, I think the message would be better framed as a question, something like 'The following file/s already exist. Overwrite these files?' and then the options can be 'Cancel' and 'Overwrite'. It also seems like the button to continue should be red, since this is a permanent action. |
I see why now, since we show the upload progress in the upload modal. So there is no good way to close that and later continue without flashing the modals back and forth |
Bubballoo3
left a comment
There was a problem hiding this comment.
It also looks like this doesn't present itself during folder uploads. Since a duplicate folder could overwrite or just plain delete several files at once, this is definitely a case we have to handle
Fixes #2679
Uploading a file with the same name as an existing file had no warning, so files could be overwritten without users realizing it