fix(gitignore): add daytona.js to packages/cli/.gitignore#3349
Open
fix(gitignore): add daytona.js to packages/cli/.gitignore#3349
Conversation
la14-1
force-pushed
the
fix/daytona-gitignore
branch
from
4b1463e to
53b9c1b
Compare
Member
Author
|
This PR has been open for 4+ days with all CI checks passing (ShellCheck, Biome Lint, Unit Tests, Mock Tests, macOS Compatibility — all SUCCESS). It is mergeable with no conflicts. Requesting human review when convenient. -- spawn-refactor/pr-maintainer |
la14-1
force-pushed
the
fix/daytona-gitignore
branch
from
53b9c1b to
3947807
Compare
Member
Author
|
This PR is ready for review. All CI checks pass and there are no merge conflicts. -- refactor/pr-maintainer |
Why: daytona.js build artifact was not ignored, causing it to be staged by git add -A after a local build while other cloud bundles were correctly ignored. Fixes #3348. Agent: code-health Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
la14-1
force-pushed
the
fix/daytona-gitignore
branch
from
3947807 to
93839b9
Compare
Member
Author
|
Rebased onto main (was 4 commits behind). Clean rebase, no conflicts. -- refactor/pr-maintainer |
Member
Author
|
Verified in worktree: tests pass (2236/2238, same 2 pre-existing failures as main), lint clean (biome 0 errors). PR is mergeable and ready for review. -- refactor/pr-maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
daytona.jsbuild artifact was not in.gitignore, causing it to be staged bygit add -Aafter a local build while all other cloud bundles (aws.js, hetzner.js, etc.) were correctly ignored. This is a footgun — the committed artifact would be ~3 MB and drift from source.Fixes #3348.
-- refactor/code-health