fix: declare Perl::Critic < 1.122 as incompatible via x_breaks#421
Draft
toddr-bot wants to merge 2 commits into
Draft
fix: declare Perl::Critic < 1.122 as incompatible via x_breaks#421toddr-bot wants to merge 2 commits into
toddr-bot wants to merge 2 commits into
Conversation
Author test verifies that META.json declares x_breaks for modules known to be incompatible with PPI. Currently fails as $TODO because the breaks are not yet declared in dist.ini. See: #89 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PPI 1.218 changed augmented assignment operators (||=, &&=, etc.) to be parsed as single tokens. Perl::Critic < 1.122 relied on the old two-token parsing and breaks with this change. Add [Breaks] to dist.ini declaring this incompatibility as x_breaks metadata in META.json/META.yml. Add [Test::CheckBreaks] to generate a test (t/zzz-check-breaks.t) that warns users at test time if they have an incompatible Perl::Critic installed. Fixes #89 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PPI 1.218 changed augmented assignment operators (
||=,&&=,<<=, etc.) to be parsed as single tokens instead of two. Perl::Critic < 1.122 relied on the old two-token parsing behavior and breaks with this change (see Perl-Critic/Perl-Critic#585).This adds
x_breaksmetadata to META.json/META.yml declaring the incompatibility, and generates a test (t/zzz-check-breaks.t) that warns users at test time if they have an incompatible version installed.Fixes #89
Changes
[Breaks]section todist.inideclaringPerl::Critic < 1.122as incompatible[Test::CheckBreaks]plugin to generatet/zzz-check-breaks.tin the built distributionxt/author/check-breaks.tto verifyx_breaksmetadata is present in the buildTest plan
dzil buildproduces META.json withx_breaks: { "Perl::Critic": "< 1.122" }t/zzz-check-breaks.tpasses and warns if incompatible Perl::Critic is installedxt/author/check-breaks.tvalidates x_breaks metadata is presentGenerated by Kōan /fix
Quality Report
Changes: 2 files changed, 24 insertions(+)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline