New cache implementation for the server#2607
Open
ljeub-pometry wants to merge 32 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 592431a | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
5 ns/iter (± 0) |
1 ns/iter (± 0) |
5 |
lotr_graph/iterate_exploded_edges |
588205 ns/iter (± 1922) |
285473 ns/iter (± 2920) |
2.06 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7837181 ns/iter (± 113918) |
1564816 ns/iter (± 35303) |
5.01 |
lotr_graph_window_100/num_nodes |
13 ns/iter (± 0) |
5 ns/iter (± 0) |
2.60 |
lotr_graph_window_100/iterate_exploded_edges |
766188 ns/iter (± 3342) |
325242 ns/iter (± 847) |
2.36 |
lotr_graph_window_100_materialise/materialize |
8161389 ns/iter (± 39733) |
1669150 ns/iter (± 10700) |
4.89 |
lotr_graph_window_10/has_node_existing |
148 ns/iter (± 6) |
62 ns/iter (± 11) |
2.39 |
lotr_graph_window_10/iterate nodes |
32062 ns/iter (± 709) |
11339 ns/iter (± 40) |
2.83 |
lotr_graph_window_10/iterate edges |
97695 ns/iter (± 1116) |
48684 ns/iter (± 211) |
2.01 |
lotr_graph_window_10/iterate_exploded_edges |
398391 ns/iter (± 2216) |
155788 ns/iter (± 1001) |
2.56 |
lotr_graph_window_10_materialise/materialize |
3601056 ns/iter (± 24862) |
971980 ns/iter (± 4278) |
3.70 |
lotr_graph_subgraph_10pc_materialise/materialize |
1665463 ns/iter (± 18088) |
334634 ns/iter (± 1287) |
4.98 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
150 ns/iter (± 6) |
62 ns/iter (± 14) |
2.42 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5547 ns/iter (± 104) |
1365 ns/iter (± 3) |
4.06 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1024134 ns/iter (± 9268) |
230399 ns/iter (± 2617) |
4.45 |
lotr_graph_window_50_layered/num_edges_temporal |
150074 ns/iter (± 2812) |
70121 ns/iter (± 7586) |
2.14 |
lotr_graph_window_50_layered/has_node_existing |
427 ns/iter (± 17) |
129 ns/iter (± 12) |
3.31 |
lotr_graph_window_50_layered/iterate nodes |
74071 ns/iter (± 1897) |
19308 ns/iter (± 47) |
3.84 |
lotr_graph_window_50_layered/iterate edges |
187566 ns/iter (± 8667) |
83616 ns/iter (± 1318) |
2.24 |
lotr_graph_window_50_layered/graph_latest |
78801 ns/iter (± 1766) |
36649 ns/iter (± 916) |
2.15 |
lotr_graph_window_50_layered_materialise/materialize |
31836273 ns/iter (± 94868) |
3488825 ns/iter (± 24948) |
9.13 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
604350 ns/iter (± 8461) |
192686 ns/iter (± 1569) |
3.14 |
lotr_graph_persistent_window_50_layered/has_node_existing |
462 ns/iter (± 311) |
174 ns/iter (± 83) |
2.66 |
lotr_graph_persistent_window_50_layered/iterate nodes |
98519 ns/iter (± 844) |
35886 ns/iter (± 191) |
2.75 |
lotr_graph_persistent_window_50_layered/iterate edges |
174431 ns/iter (± 671) |
84161 ns/iter (± 596) |
2.07 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4388997 ns/iter (± 52137) |
1659940 ns/iter (± 19402) |
2.64 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
56440067 ns/iter (± 734323) |
5298035 ns/iter (± 147912) |
10.65 |
lotr_graph/proto_encode |
9438456 ns/iter (± 88389) |
1157897 ns/iter (± 73709) |
8.15 |
This comment was automatically generated by workflow using github-action-benchmark.
…rver is started without giving a specific port
…ph when inserting with disk storage enabled
…oid any potential ordering issues in the test
… are dropped before the directory is deleted
…deleted before the graph is dropped and enable panic on drop for graphql tests by default
fabianmurariu
requested changes
May 20, 2026
Collaborator
fabianmurariu
left a comment
There was a problem hiding this comment.
LGTM, small changes
…rstand and make sure vectorisation is working correctly
…s due to directory being cleaned up too early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?