fix: accessibility, reduced motion, and anti-pattern cleanup#5
Open
Jing-yilin wants to merge 1 commit intomainfrom
Open
fix: accessibility, reduced motion, and anti-pattern cleanup#5Jing-yilin wants to merge 1 commit intomainfrom
Jing-yilin wants to merge 1 commit intomainfrom
Conversation
- Add global :focus-visible indicator (P0: keyboard users can now see focus) - Remove outline-none from all inputs (rely on global focus-visible) - Wrap all CSS animations in prefers-reduced-motion: no-preference - GlowMesh renders static gradient fallback for reduced-motion users - Add ARIA labels/roles to spinners, decorative SVGs, icon buttons - Add focus trap + role=dialog to onboarding modal - Add semantic <nav> and <footer> landmarks - Remove banned gradient text CSS classes (.text-gradient, .text-gradient-blue) - Remove backdrop-blur-sm from 13/14 surfaces (kept only on modal overlay) - Replace animate-bounce with animate-pulse on skeleton dots - Restyle SkillPreview to match dark/sharp aesthetic (was using light-mode vars) - Fix unescaped entity in onboarding modal Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish pass addressing findings from a technical audit (score: 8/20 → estimated 14-15/20 after this PR).
P0 (Blocking) — Fixed
:focus-visibleindicator — keyboard users can now see focus on every interactive elementoutline-nonefrom all inputs; they now rely on the global focus-visible ringP1 (Major) — Fixed
prefers-reduced-motionsupport — all CSS animations wrapped in@media (prefers-reduced-motion: no-preference)useSyncExternalStoreto avoid lint issues)role="status"), decorative SVGs (aria-hidden), icon-only buttons (aria-label), error containers (role="alert"), and timer display (role="timer")<nav aria-label="Main navigation">in header,<nav aria-label="Footer links">in footerP2 (Minor) — Fixed
.text-gradientand.text-gradient-blueclasses (violated absolute ban onbackground-clip: text+ gradient)backdrop-blur-smfrom 13/14 surfaces — kept only on onboarding modal overlay where it serves a functional purposeanimate-bouncewithanimate-pulseon skeleton loading dotsSkillPreview— was using light-mode CSS vars +rounded-xl; now matches dark/sharp aestheticP3 (Polish) — Fixed
role="dialog",aria-modal="true", Tab cycling)<nav>with aria-labelYou're→You'rein onboarding modalVerification
Files changed (15)
globals.css,glow-mesh.tsx,site-header.tsx,onboarding-modal.tsx,config-panel.tsx,provider-config.tsx,launch-progress.tsx,session-control.tsx,sandbox-skeleton.tsx,skill-preview.tsx,skill-tree.tsx,page.tsx(home),[...skillPath]/page.tsx,dashboard/page.tsx,settings/page.tsx